-
Notifications
You must be signed in to change notification settings - Fork 142
hold the bc settings per plotter instance #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hold the bc settings per plotter instance #3897
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request refactors boundary condition (BC) plot settings to be instance-specific rather than global. It introduces a File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## check-installed-without-import #3897 +/- ##
==================================================================
- Coverage 88.28% 88.28% -0.01%
==================================================================
Files 187 187
Lines 14823 14830 +7
==================================================================
+ Hits 13087 13092 +5
- Misses 1736 1738 +2 🚀 New features to boost your workflow:
|
…ing ansys.mapdl.core (#3887) * change how the install check works * chore: adding changelog file 3887.miscellaneous.md [dependabot-skip] * chore: adding changelog file 3887.added.md [dependabot-skip] * don't expect requests to be loaded on import * only set the default theme once * use default symbol * Don't import plotter from visualizer by default Don't import plotter from post module * ci: auto fixes from pre-commit.com hooks. for more information, see https://pre-commit.ci * remove global import of Plotter * chore: adding changelog file 3887.added.md [dependabot-skip] * cicd: empty commit to retrigger CICD * fix ci * update * fix autodoc * hold the bc settings per plotter instance (#3897) * hold the bc settings per plotter instance * ci: auto fixes from pre-commit.com hooks. for more information, see https://pre-commit.ci * chore: adding changelog file 3897.miscellaneous.md [dependabot-skip] --------- Co-authored-by: Mohamed Koubaa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> * add docstring * type hint --------- Co-authored-by: Mohamed Koubaa <[email protected]> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: German <[email protected]>
Summary by Sourcery
Modify the visualizer to hold BC (boundary condition) settings per plotter instance instead of using a global variable
Enhancements: