Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 21, 2025

Description

Better annotations on launch_mapdl. Also reordering arguments to be alphabetically ordered.
Improving docstring.

Issue linked

Close #3813

Checklist

@germa89 germa89 requested a review from a team as a code owner April 21, 2025 16:47
@germa89 germa89 self-assigned this Apr 21, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (3801fe4) to head (4b6f9b9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3855      +/-   ##
==========================================
- Coverage   88.30%   88.29%   -0.02%     
==========================================
  Files         187      187              
  Lines       14819    14819              
==========================================
- Hits        13086    13084       -2     
- Misses       1733     1735       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 22, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) April 22, 2025 11:34
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 72427c9 into main Apr 22, 2025
48 checks passed
@germa89 germa89 deleted the fix/annotate-launch_mapdl branch April 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type hints on launcher

3 participants