Skip to content

Conversation

@jgd10
Copy link
Contributor

@jgd10 jgd10 commented Apr 14, 2025

The examples don't contain any examples demonstrating conversion from APDL to PyMAPDL scripts. In this, I do just that.

This example does not download any files and uses a modified version of vm45 that has been hardcoded in. Otherwise, the example does save this file to a temp folder using tempfile, and then loads it again to do the conversion.

Description

New example in the Miscellaneous section.

Issue linked

There was no example demonstrating conversion from APDL scripts.

Checklist

The examples conspicuously don't contain any examples demonstarting
conversion from APDL to PyMAPDL scripts. In this, I do just that.

This example does not download any files and uses a modified version of
vm45 that has been hardcoded in. Otherwise, the example does save this
file to a temp folder using tempfile, and then loads it again to do the
conversion.
@jgd10 jgd10 requested a review from a team as a code owner April 14, 2025 15:05
@jgd10 jgd10 requested review from clatapie and germa89 April 14, 2025 15:05
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) labels Apr 14, 2025
@jgd10 jgd10 self-assigned this Apr 14, 2025
@jgd10 jgd10 changed the title Created self-contained apdl/pymapdl conversion ex docs: create self-contained apdl/pymapdl conversion example Apr 14, 2025
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jgd10

Thank you a lot for taking the time to publish this PR on PyMAPDL repo.
We always welcome contributions.

Overall, I like the idea. We were missing an example on the converter. I just added some small suggestions to it. Feel free to discard them if you do not see them appropriated or do not have the time.

@jgd10
Copy link
Contributor Author

jgd10 commented Apr 14, 2025 via email

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (3801fe4) to head (ca41b9e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3840      +/-   ##
==========================================
- Coverage   88.30%   88.29%   -0.02%     
==========================================
  Files         187      187              
  Lines       14819    14819              
==========================================
- Hits        13086    13084       -2     
- Misses       1733     1735       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 requested review from PipKat and removed request for clatapie April 15, 2025 13:07
@germa89
Copy link
Collaborator

germa89 commented Apr 15, 2025

@PipKat can you have a look at the writing of this example, to make sure it aligns with the PyMAPDL and PyAnsys examples??

@PipKat
Copy link
Member

PipKat commented Apr 15, 2025 via email

@germa89
Copy link
Collaborator

germa89 commented Apr 16, 2025

@PipKat I think there is no rush, you can do the review today or tomorrow.

Am I right @jgd10?

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed to style guide, with most changes related to using active voice and for proper formatting in the generated doc. The use of "method" versus "function" must be decided on and used consistently. Other comments are inline.

@germa89 germa89 enabled auto-merge (squash) April 21, 2025 08:56
@germa89 germa89 merged commit 27c6e96 into main Apr 21, 2025
50 checks passed
@germa89 germa89 deleted the doc/example-apdl-to-pymapdl branch April 21, 2025 11:11
@jgd10
Copy link
Contributor Author

jgd10 commented Apr 24, 2025

Excellent! Thanks all!

@germa89
Copy link
Collaborator

germa89 commented Apr 24, 2025

Thank @jgd10 for taking the time! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related (improving, adding, etc) examples Publishing PyMAPDL examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants