-
Notifications
You must be signed in to change notification settings - Fork 142
docs: create self-contained apdl/pymapdl conversion example #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The examples conspicuously don't contain any examples demonstarting conversion from APDL to PyMAPDL scripts. In this, I do just that. This example does not download any files and uses a modified version of vm45 that has been hardcoded in. Otherwise, the example does save this file to a temp folder using tempfile, and then loads it again to do the conversion.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jgd10
Thank you a lot for taking the time to publish this PR on PyMAPDL repo.
We always welcome contributions.
Overall, I like the idea. We were missing an example on the converter. I just added some small suggestions to it. Feel free to discard them if you do not see them appropriated or do not have the time.
|
[like] James Derrick reacted to your message:
...
**REDACTED**
|
Co-authored-by: German <[email protected]>
Co-authored-by: German <[email protected]>
Co-authored-by: German <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
==========================================
- Coverage 88.30% 88.29% -0.02%
==========================================
Files 187 187
Lines 14819 14819
==========================================
- Hits 13086 13084 -2
- Misses 1733 1735 +2 🚀 New features to boost your workflow:
|
…s/pymapdl into doc/example-apdl-to-pymapdl
for more information, see https://pre-commit.ci
…ple-apdl-to-pymapdl
…s/pymapdl into doc/example-apdl-to-pymapdl
…ple-apdl-to-pymapdl
|
@PipKat can you have a look at the writing of this example, to make sure it aligns with the PyMAPDL and PyAnsys examples?? |
|
Hey there. I just finished a big review of PyAnsys Heart. I can take a look at this tomorrow if the PR is still open!
…________________________________
From: German ***@***.***>
Sent: Tuesday, April 15, 2025 9:08 AM
To: ansys/pymapdl ***@***.***>
Cc: Kathy Pippert ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pymapdl] docs: create self-contained apdl/pymapdl conversion example (PR #3840)
[External Sender]
@PipKat<https://github.com/PipKat> can you have a look at the writing of this example, to make sure it aligns with the PyMAPDL and PyAnsys examples??
—
Reply to this email directly, view it on GitHub<#3840 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHQY23RHWQ7WGX4VJEMGOT2ZUAE7AVCNFSM6AAAAAB3DHFNKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBVGAYDEMJRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/28149841?s=20&v=4]germa89 left a comment (ansys/pymapdl#3840)<#3840 (comment)>
@PipKat<https://github.com/PipKat> can you have a look at the writing of this example, to make sure it aligns with the PyMAPDL and PyAnsys examples??
—
Reply to this email directly, view it on GitHub<#3840 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHQY23RHWQ7WGX4VJEMGOT2ZUAE7AVCNFSM6AAAAAB3DHFNKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBVGAYDEMJRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…ple-apdl-to-pymapdl
…s/pymapdl into doc/example-apdl-to-pymapdl
Co-authored-by: Kathy Pippert <[email protected]>
PipKat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed to style guide, with most changes related to using active voice and for proper formatting in the generated doc. The use of "method" versus "function" must be decided on and used consistently. Other comments are inline.
Co-authored-by: Kathy Pippert <[email protected]>
for more information, see https://pre-commit.ci
|
Excellent! Thanks all! |
|
Thank @jgd10 for taking the time! :) |
The examples don't contain any examples demonstrating conversion from APDL to PyMAPDL scripts. In this, I do just that.
This example does not download any files and uses a modified version of vm45 that has been hardcoded in. Otherwise, the example does save this file to a temp folder using
tempfile, and then loads it again to do the conversion.Description
New example in the Miscellaneous section.
Issue linked
There was no example demonstrating conversion from APDL scripts.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)