Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 11, 2025

Description

As the title.

Issue linked

Close #3831
Close #3625

Checklist

@germa89 germa89 requested a review from a team as a code owner April 11, 2025 16:20
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Apr 11, 2025
@germa89 germa89 requested a review from a team April 11, 2025 16:21
@germa89 germa89 self-assigned this Apr 11, 2025
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (6addc88) to head (a527d53).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3834      +/-   ##
==========================================
- Coverage   88.51%   88.36%   -0.15%     
==========================================
  Files         187      187              
  Lines       14761    14761              
==========================================
- Hits        13065    13044      -21     
- Misses       1696     1717      +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 11, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) April 11, 2025 17:54
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit d2791d3 into main Apr 11, 2025
52 checks passed
@germa89 germa89 deleted the ci/using-ansys-actions-v9 branch April 11, 2025 17:54
steps:
- name: "Release to the public PyPI repository"
uses: ansys/actions/release-pypi-public@v8
uses: ansys/actions/release-pypi-public@v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to reimplement this action following the migration guide @germa89 -- otherwise it is going to fail the next time you do a release

Copy link
Collaborator Author

@germa89 germa89 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did use the migration guide (referenced in the issue I did for this #3831). But maybe I missunderstood, I thought that if I do not use trusted_publisher I could use the standard composite action...

Anyways #3837 should fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were using the trusted-publisher approach -- you no longer had a dedicated token to upload to PyPI. Meaning, that you needed to migrate to the new method for publishing wheels using the trusted publisher. Thanks for opening #3837!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate ansys/actions@v9 Remove attrs from whitelist packages

4 participants