Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 7, 2025

Description

Fix some exceptions raised on tests when deleting mapdl class:

tests/test_mapdl.py::test_jobname PASSED                                 [ 15%]
tests/test_mapdl.py::test_path_with_single_quote PASSED                  [ 15%]
tests/test_mapdl.py::test_ip_hostname_in_start_parm[myhostname] PASSED   [ 15%]Exception ignored in: <function MapdlGrpc.__del__ at 0x7fcc395860c0>
Traceback (most recent call last):
  File "/__t/Python/3.12.9/x64/lib/python3.12/site-packages/ansys/mapdl/core/mapdl_grpc.py", line 3858, in __del__
    self.kill_job(self.jobid)
  File "/__t/Python/3.12.9/x64/lib/python3.12/site-packages/ansys/mapdl/core/mapdl_grpc.py", line 3839, in kill_job
    subprocess.Popen(cmd)  # nosec B603
    ^^^^^^^^^^^^^^^^^^^^^
  File "/__t/Python/3.12.9/x64/lib/python3.12/subprocess.py", line 1028, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/__t/Python/3.12.9/x64/lib/python3.12/subprocess.py", line 1963, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'scancel'
tests/test_mapdl.py::test_none_on_selecting[lsel] PASSED                 [ 15%]

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

@germa89 germa89 self-assigned this Apr 7, 2025
@germa89 germa89 requested a review from a team as a code owner April 7, 2025 18:25
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (6addc88) to head (9166f87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3826      +/-   ##
==========================================
- Coverage   88.51%   88.36%   -0.15%     
==========================================
  Files         187      187              
  Lines       14761    14761              
==========================================
- Hits        13065    13044      -21     
- Misses       1696     1717      +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 11, 2025

It seems there is no more exception messages on the CICD. Merging....

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) April 11, 2025 16:03
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit f422758 into main Apr 11, 2025
48 checks passed
@germa89 germa89 deleted the fix/exceptions-on-mapdl-deletion-on-tests branch April 11, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants