-
Notifications
You must be signed in to change notification settings - Fork 142
feat: Add optional graphical target and rework graphics backend selection #3820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3820 +/- ##
==========================================
- Coverage 88.36% 88.29% -0.08%
==========================================
Files 187 187
Lines 14761 14819 +58
==========================================
+ Hits 13044 13084 +40
- Misses 1717 1735 +18 🚀 New features to boost your workflow:
|
…pymapdl into fix/optional-visualizer
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Roberto Pastor Muela <[email protected]>
|
Before going forward and modify the examples, do you agree with this approach for backend selection @germa89 @RobPasMue ? User facing API would change like this: |
|
@AlejandroFernandezLuces I did figure out what was the problem with the tests. There was a few:
|
for more information, see https://pre-commit.ci
|
@AlejandroFernandezLuces are we missing anything here? Btw, title must be changed since the scope has expanded . |
|
I was waiting for your feedback on the conversation about the decorator, from my side it is good to go as is. If you want to expand the current implementation of the decorator let me know. Also, vulnerability check is failing, but it doesn't seem to be failing in anything I've modified.. |
I just replied to the thread. Do not bother about the vulnerability check. We will merge without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me.
One last request will be to have a warning/exception if an user is using the old vtk argument. I am concerned that this argument might be passed around in the kwargs without having effect. Please do also add a test for this check.
Probably this is a good case for a decorator.
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great! Thank you a lot @AlejandroFernandezLuces ! Great work!
Co-authored-by: German <[email protected]>
Description
Add a separate optional target from graphics installation, as required in ansys/pyansys#902
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)