Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 30, 2025

Description

Add PYMAPDL_ADDITIONAL_SWITCHES env var to allow injecting additional switches in PyMAPDL launcher.

Issue linked

NA, but this is an issue raised in #3805 and in docker container builder repo.

Checklist

@germa89 germa89 requested a review from a team as a code owner March 30, 2025 09:44
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Mar 30, 2025
@codecov
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (16508b7) to head (615934a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3817      +/-   ##
==========================================
- Coverage   88.44%   88.39%   -0.05%     
==========================================
  Files         187      187              
  Lines       14751    14760       +9     
==========================================
+ Hits        13046    13047       +1     
- Misses       1705     1713       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 changed the title feat(launcher): add function to inject additional command line switches through an env var feat: inject additional MAPDL command line arguments through an env var Apr 1, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Apr 1, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) April 1, 2025 15:55
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 48e9ad6 into main Apr 1, 2025
51 checks passed
@germa89 germa89 deleted the feat/adding-pymapdl_additional_switches-env-var branch April 1, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants