Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 25, 2025

Description

Fix setting set_no_abort equals to None which makes that the default behaviour is to NOT set to not abort MAPDL.
This generates crashes when found few (or many) MAPDL errors.

Issue linked

Close #3809
Close #3447

Checklist

@germa89 germa89 requested a review from a team as a code owner March 25, 2025 20:33
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Mar 25, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Mar 25, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Mar 25, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (16508b7) to head (4d5fc10).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
- Coverage   88.44%   88.40%   -0.04%     
==========================================
  Files         187      187              
  Lines       14751    14752       +1     
==========================================
- Hits        13046    13041       -5     
- Misses       1705     1711       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit 2ddaf4c into main Apr 1, 2025
53 of 54 checks passed
@germa89 germa89 deleted the fix/aborting-MAPDL branch April 1, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyMAPDL not being able to reconnect PyMAPDL closes gRPC connection when an error occurs in SOLVE command

3 participants