Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 4, 2025

Description

Fix crashes when having uncomplete selections.

Now, under the hood, for plotting nodes PyMAPDL will select the elements those nodes belong to so we can plot them and avoid crashes.

Issue linked

Close #3782

Checklist

@germa89 germa89 requested a review from a team as a code owner March 4, 2025 16:42
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Mar 4, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Mar 4, 2025
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (500043e) to head (bb9cb6c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3784      +/-   ##
==========================================
+ Coverage   88.35%   88.36%   +0.01%     
==========================================
  Files         187      187              
  Lines       14733    14738       +5     
==========================================
+ Hits        13017    13023       +6     
+ Misses       1716     1715       -1     

@germa89
Copy link
Collaborator Author

germa89 commented Mar 4, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 enabled auto-merge (squash) March 5, 2025 09:36
@germa89 germa89 merged commit c9f0348 into main Mar 5, 2025
46 of 47 checks passed
@germa89 germa89 deleted the fix/plotting-incomplete-selections branch March 5, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete plots fails when nodes are selected

3 participants