Skip to content

Conversation

@SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Feb 27, 2025

Description

Temporary avoid using the latest version of flit due to issues when releasing to PyPI with https://github.com/pypa/gh-action-pypi-publish. The problem comes from the new metadata format used to release and the fact the version of pypa/gh-action-pypi-publish we are using is not compatible with is. However, using a newer version is a problem, see ansys/actions#687 for more information on the blocking changes.

Issue linked

None

Checklist

Temporary avoid using the latest version of flit due to issues when releasing to PyPI with https://github.com/pypa/gh-action-pypi-publish. The problem comes from the new metadata format used to release and the fact the version of `pypa/gh-action-pypi-publish` we are using is not compatible with is. However, using a newer version is a problem, see ansys/actions#687 for more information on the blocking changes.
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner February 27, 2025 07:27
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Feb 27, 2025
@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 27, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.35%. Comparing base (99a4b96) to head (526cfbe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3771      +/-   ##
==========================================
- Coverage   88.40%   88.35%   -0.05%     
==========================================
  Files         187      187              
  Lines       14717    14717              
==========================================
- Hits        13010    13003       -7     
- Misses       1707     1714       +7     

@SMoraisAnsys
Copy link
Contributor Author

@germa89 I don't think the current error (see below) is related to my changes, any idea of why this would have appeared ?

[FAILED] TestMapdlPool.test_directory_names_function - E AssertionError: assert 'Other_instance' in ['instance_zero', 'instance_one']

@germa89
Copy link
Collaborator

germa89 commented Feb 27, 2025

Thank you @SMoraisAnsys for this PR! It comes in the right hour!

@germa89 I don't think the current error (see below) is related to my changes, any idea of why this would have appeared?

That is a typical flaky test in PyMAPDL. I have a branch that aims to fix it but for the moment, I will just rerun/merge this :)

@germa89 germa89 merged commit a2f8098 into main Feb 27, 2025
50 of 51 checks passed
@germa89 germa89 deleted the build/temporary-add-upper-bound-to-flit-core branch February 27, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants