Skip to content

ci: enhance CI testing by summarizing tests durations #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
germa89 merged 19 commits into from
Feb 25, 2025
Merged

ci: enhance CI testing by summarizing tests durations #3754

germa89 merged 19 commits into from
Feb 25, 2025

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 19, 2025

As the title.

@germa89 germa89 requested a review from a team as a code owner February 19, 2025 15:58
@ansys-reviewer-bot
Copy link
Contributor

ansys-reviewer-bot bot commented Feb 19, 2025

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 19, 2025
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 19, 2025
@codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (4c6e65a) to head (fbc9f59).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
+ Coverage   88.35%   88.38%   +0.03%     
==========================================
  Files         187      187              
  Lines       14704    14719      +15     
==========================================
+ Hits        12991    13009      +18     
+ Misses       1713     1710       -3

@germa89
Copy link
Collaborator Author

germa89 commented Feb 20, 2025

Close #3752

@germa89 germa89 linked an issue Feb 20, 2025 that may be closed by this pull request
Average test time on CICD #3752
Closed
@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2025

Future work: Consider using tabulate (to avoid creating the tables ourselves), and/or click-extras (for more facilities).

@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2025 •
edited
Loading

Output summary:

https://github.com/ansys/pymapdl/actions/runs/13454381188/attempts/1#summary-37596369652

@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2025

I do not think pytest-durations is needed for this.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 25, 2025

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit f2e2533 into main Feb 25, 2025
53 of 54 checks passed
@germa89 germa89 deleted the feat/adding-pytest-durations-and-reportlog branch February 25, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels

CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Average test time on CICD

3 participants

@germa89 @pyansys-ci-bot