Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 12, 2025

Description

As the title.

Issue linked

Close #3735

Checklist

@germa89 germa89 requested a review from a team as a code owner February 12, 2025 10:19
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 12, 2025
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.28%. Comparing base (b39d487) to head (0aeb1f3).
Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (7.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   88.27%   88.28%   +0.01%     
==========================================
  Files         187      187              
  Lines       14705    14704       -1     
==========================================
+ Hits        12981    12982       +1     
+ Misses       1724     1722       -2     

@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 14, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Feb 14, 2025

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot removed dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 14, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Feb 17, 2025

93513c0 reduced the teardown of the pool fixture from 20s to 5s by avoiding respawning.

@germa89 germa89 merged commit e515e96 into main Feb 17, 2025
50 of 51 checks passed
@germa89 germa89 deleted the tests/improving-pool-testing branch February 17, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pool testing fails quite frequently while respawning

3 participants