Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 24, 2025

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner January 24, 2025 15:47
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 24, 2025
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (a2f91e6) to head (8238ea8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   87.88%   88.20%   +0.31%     
==========================================
  Files         187      187              
  Lines       14710    14712       +2     
==========================================
+ Hits        12928    12976      +48     
+ Misses       1782     1736      -46     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 24, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) January 24, 2025 17:23
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented Jan 27, 2025

It seems that requires_package is very slow:

image

@germa89 germa89 merged commit 7e86b2a into main Jan 27, 2025
42 of 47 checks passed
@germa89 germa89 deleted the test/testing-performance branch January 27, 2025 12:27
@germa89 germa89 restored the test/testing-performance branch January 27, 2025 13:39
@germa89
Copy link
Collaborator Author

germa89 commented Jan 27, 2025

I see that raising and handling exceptions can be quite costly.

For instance, when having exceptions while logging during exiting, the traceback can take up to 10s?!?!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants