Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jan 24, 2025

Description

This PR improves the usability of some methods in the plotting class. This class was meant to be used inside eplot, vplot.. functions, but since some use cases involve using it standalone, I improved it's usability and documentation.

Checklist

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (9f5e4e9) to head (6718ab3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
- Coverage   88.38%   88.37%   -0.01%     
==========================================
  Files         187      187              
  Lines       14742    14751       +9     
==========================================
+ Hits        13029    13036       +7     
- Misses       1713     1715       +2     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlejandroFernandezLuces
Copy link
Contributor Author

@clatapie This PR fixes your original issue. I'm unsure if more issues will arise, since plots are not throwing errors and I do not know how plots should look like. I would need to compare results from the original examples to what we have right now for further debugging.

From my point of view, we can either merge this PR and we can add more fixes as issues arise, or you can install this branch in your local and ping me when something does not look as expected. What do you think?

@AlejandroFernandezLuces AlejandroFernandezLuces changed the title fix(plotting): Test plotting changes fix(plotting): Improve interface of the plotting class. Jan 27, 2025
@clatapie
Copy link
Contributor

Thanks for fixing the error @AlejandroFernandezLuces!
I will use this branch in the PyMAPDL-Example PR and check the documentation output so that we will have it tested with a broader range of examples

@germa89
Copy link
Collaborator

germa89 commented Feb 26, 2025

@AlejandroFernandezLuces any update on this? Is this planned?

@AlejandroFernandezLuces
Copy link
Contributor Author

This is pending @clatapie PR in ansys/pymapdl-examples#281. This PR intends to fix some issues that arise in that PR. @clatapie let me know if you need any help 🙂

@clatapie
Copy link
Contributor

I confirm that the issue has correctly been addressed with this fix. Thank you @AlejandroFernandezLuces!

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review March 13, 2025 12:10
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner March 13, 2025 12:10
@germa89
Copy link
Collaborator

germa89 commented Mar 13, 2025

This PR needs a bit more coverage before being merged.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the coverage before merging. Plotting is an important feature and needs to be as much tested as possible.

@AlejandroFernandezLuces
Copy link
Contributor Author

@germa89 increased coverage to 100%. I'm seeing an issue with the CI in this PR, it seems that there is a required job that does not exist:

image

Is this an specific problem for this PR or is it general?

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 116fcd1 into main Mar 17, 2025
49 checks passed
@germa89 germa89 deleted the fix/plotter-issues branch March 17, 2025 18:50
@germa89
Copy link
Collaborator

germa89 commented Mar 17, 2025

@germa89 increased coverage to 100%. I'm seeing an issue with the CI in this PR, it seems that there is a required job that does not exist:

image

Is this an specific problem for this PR or is it general?

@AlejandroFernandezLuces it was my fault. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants