Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 23, 2025

Description

Adding tests to make sure the conversion None to "None" is correct.

Issue linked

Close #3660

Checklist

@germa89 germa89 requested a review from a team as a code owner January 23, 2025 14:24
@germa89 germa89 self-assigned this Jan 23, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jan 23, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Jan 24, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (e6221a6) to head (216a678).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3694      +/-   ##
==========================================
- Coverage   87.14%   87.07%   -0.07%     
==========================================
  Files         187      187              
  Lines       14697    14698       +1     
==========================================
- Hits        12808    12799       -9     
- Misses       1889     1899      +10     

@germa89 germa89 merged commit ef03721 into main Jan 24, 2025
47 of 48 checks passed
@germa89 germa89 deleted the test/adding-test-for-None-arguments branch January 24, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow None for XSEL commands

3 participants