-
Notifications
You must be signed in to change notification settings - Fork 142
chore: active support for Python 3.13 #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 88.30% 88.29% -0.02%
==========================================
Files 187 187
Lines 14819 14819
==========================================
- Hits 13086 13084 -2
- Misses 1733 1735 +2 🚀 New features to boost your workflow:
|
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when @RobPasMue suggestions have beem implemented.
|
Only VTK 9.4.0 is compatible with 3.13 |
|
Thanks @RobPasMue. I updated all the vtk versions, including the ones within |
|
Seems to me like you are hitting some PyVista 3.13 incompatibilities. |
Yep. This is on hold until ansys/ansys-tools-visualization-interface#208 is fixed. |
|
We are going to need a patch release in ATVI ( |
|
@RobPasMue @MaxJPRey @clatapie .... well.. that was unexpected. |
Reviewer's GuideThis pull request implements active support for Python 3.13 by modifying CI workflows to include 3.13 in test matrices and configurations, updating project files (pyproject.toml, tox.ini) to reflect Python 3.13 compatibility and version ranges, and upgrading the VTK dependency. Issue templates and the changelog were also updated to include Python 3.13. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clatapie - I've reviewed your changes - here's some feedback:
- Consider using a workflow input or a global variable for the Python version in
ci.ymljobs (e.g.,check-vulnerabilities,build-library) instead of hardcoding '3.13' directly. - The
vtkdependency is updated inpyproject.tomlbut removed from devcontainer requirement files; please clarify if this discrepancy is intended. - The
test-localworkflow now installs the package viapython -m pip install .instead of building/installing a wheel; confirm this change in installation strategy.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@RobPasMue building the wheels also works (It should anyways). So I am merging now. |
|
Great news! |


Description
Active support for Python 3.13
Closes #3600
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Add active support for Python 3.13 across the project's workflows, configuration, and dependencies
New Features:
CI:
Chores: