Skip to content

feat(action): Allow users to override python_version #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(action): Allow users to override python_version #4829

wants to merge 5 commits into from
+9 −1

Conversation

@konstruktoid
Copy link
Contributor

@konstruktoid konstruktoid commented Oct 29, 2025 •
edited by ssbarnea
Loading

Closes: #4830

@konstruktoid
add python_version support
4aa85fc 
Signed-off-by: Thomas Sjögren <[email protected]>
@konstruktoid konstruktoid requested a review from a team as a code owner October 29, 2025 17:14
@konstruktoid
Copy link
Contributor Author

konstruktoid commented Oct 29, 2025

Reference workflow:
https://github.com/konstruktoid/ansible-role-docker-rootless/actions/runs/18916562673

https://github.com/konstruktoid/ansible-role-docker-rootless/actions/runs/18916562673/workflow

@konstruktoid konstruktoid changed the title add python_version support [GitHub action] add python_version support Oct 29, 2025
@Honny1 Honny1 mentioned this pull request Oct 29, 2025
Merged
@konstruktoid konstruktoid mentioned this pull request Oct 30, 2025
Open
@konstruktoid
Copy link
Contributor Author

konstruktoid commented Oct 30, 2025

Closes #4830

@jtonl
Copy link

jtonl commented Oct 30, 2025

Thanks for this @konstruktoid, though it gave me a good chuckle why it wasn't in the codebase before.

@konstruktoid konstruktoid mentioned this pull request Oct 30, 2025
Merged
@sdodsley sdodsley mentioned this pull request Oct 30, 2025
Merged
Dylancyclone added a commit to Dylancyclone/ansible-homelab-orchestration that referenced this pull request Oct 31, 2025
@Dylancyclone
ci(ansible-lint): fix ansible-lint not working because of invalid pyt…
702b6f7 
…hon version

The latest version of ansible-nas uses Python 3.14, which requires at least ansible-core version 2.20, which isn't out yet.
To avoid constantly failing tests, we manually install Python 3.12

This commit should be reverted once:
- ansible-core 2.20 comes out
- This PR gets merged, allowing us to specify the python version: ansible/ansible-lint#4829

ansible/ansible-lint#4830
@Qalthos Qalthos added the feat label Nov 6, 2025
@ssbarnea ssbarnea changed the title [GitHub action] add python_version support feat(action): Allow users to override python_version Nov 20, 2025
@ssbarnea ssbarnea self-assigned this Nov 20, 2025
@github-actions github-actions bot added feat and removed feat labels Nov 20, 2025
@ssbarnea ssbarnea mentioned this pull request Nov 20, 2025
Closed
@github-actions github-actions bot added feat and removed feat labels Nov 21, 2025
@alisonlhart
Copy link
Contributor

alisonlhart commented Nov 21, 2025

Thanks for the contribution @konstruktoid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees

@ssbarnea ssbarnea

Labels

feat

Projects

🧰 devtools project board
Status: Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ubuntu-24.04 runner fails with incompatible ansible and python versions

5 participants

@konstruktoid @jtonl @alisonlhart @ssbarnea @Qalthos