Make rule deprecated-local-action preserve module parameters

examples/playbooks/tasks/local_action.transformed.yml

@@ -1,4 +1,11 @@
 ---
-- name: Sample
-  ansible.builtin.command: echo 123
+- name: Sample 1
+  command: echo 123
+  delegate_to: localhost
+- name: Sample 2
+  command:
+    cmd: echo 456
+  delegate_to: localhost
+- name: Sample 3
+  ansible.builtin.debug:
   delegate_to: localhost

examples/playbooks/tasks/local_action.yml

@@ -1,3 +1,9 @@
 ---
-- name: Sample
+- name: Sample 1
   local_action: command echo 123
+- name: Sample 2
+  local_action:
+    module: command
+    cmd: echo 456
+- name: Sample 3
+  local_action: ansible.builtin.debug

src/ansiblelint/rules/deprecated_local_action.md

@@ -16,7 +16,7 @@ This rule recommends using `delegate_to: localhost` instead of the
 
 ```yaml
 - name: Task example
-    ansible.builtin.debug:
+  ansible.builtin.debug:
   delegate_to: localhost # <-- recommended way to run on localhost
 ```
 

src/ansiblelint/rules/deprecated_local_action.py

@@ -9,7 +9,7 @@
 import os
 import sys
 from pathlib import Path
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
 from ansiblelint.rules import AnsibleLintRule, TransformMixin
 from ansiblelint.runner import get_matches
@@ -53,19 +53,27 @@ def transform(
         data: CommentedMap | CommentedSeq | str,
     ) -> None:
         if match.tag == self.id:
-            # we do not want perform a partial modification accidentally
             original_target_task = self.seek(match.yaml_path, data)
-            target_task = copy.deepcopy(original_target_task)
-            for _ in range(len(target_task)):
-                k, v = target_task.popitem(False)
+            assert "local_action" in original_target_task
+            target_task: dict[str, Any] = {}
+
+            for k, v in original_target_task.items():
                 if k == "local_action":
                     if isinstance(v, dict):
-                        module_name = v["module"]
-                        target_task[module_name] = None
+                        assert "module" in v
+                        target_task[v["module"]] = copy.deepcopy(v)
+                        target_task[v["module"]].pop("module", None)
+
+                        if target_task[v["module"]] == {}:
+                            target_task[v["module"]] = None
+
                         target_task["delegate_to"] = "localhost"
                     elif isinstance(v, str):
-                        module_name, module_value = v.split(" ", 1)
-                        target_task[module_name] = module_value
+                        tokens = v.split(" ", 1)
+                        if len(tokens) > 1:
+                            target_task[tokens[0]] = tokens[1]
+                        else:
+                            target_task[tokens[0]] = None
                         target_task["delegate_to"] = "localhost"
                     else:  # pragma: no cover
                         _logger.debug(
@@ -75,6 +83,7 @@ def transform(
                         return
                 else:
                     target_task[k] = v
+
         match.fixed = True
         original_target_task.clear()
         original_target_task.update(target_task)
@@ -94,27 +103,27 @@ def test_local_action(default_rules_collection: RulesCollection) -> None:
             rules=default_rules_collection,
         ).run()
 
-        assert len(results) == 1
-        assert results[0].tag == "deprecated-local-action"
+        assert any(result.tag == "deprecated-local-action" for result in results)
 
     @mock.patch.dict(os.environ, {"ANSIBLE_LINT_WRITE_TMP": "1"}, clear=True)
     def test_local_action_transform(
         config_options: Options,
-        default_rules_collection: RulesCollection,
     ) -> None:
         """Test transform functionality for no-log-password rule."""
         playbook = Path("examples/playbooks/tasks/local_action.yml")
         config_options.write_list = ["all"]
 
         config_options.lintables = [str(playbook)]
+        only_local_action_rule: RulesCollection = RulesCollection()
+        only_local_action_rule.register(TaskNoLocalActionRule())
         runner_result = get_matches(
-            rules=default_rules_collection,
+            rules=only_local_action_rule,
             options=config_options,
         )
         transformer = Transformer(result=runner_result, options=config_options)
         transformer.run()
         matches = runner_result.matches
-        assert len(matches) == 3
+        assert any(error.tag == "deprecated-local-action" for error in matches)
 
         orig_content = playbook.read_text(encoding="utf-8")
         expected_content = playbook.with_suffix(