Look for ansible binary in the same path as we are #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FliegenKLATSCH
requested review from
a team,
cristianonicolai and
shatakshiiii
and removed request for
a team
ssbarnea
previously requested changes
Nov 27, 2023
Member
ssbarnea
left a comment
ssbarnea
left a comment
There was a problem hiding this comment.
This will clearly not work as expected if linter is called as a python module as in this case argv[0] will be just python.
Contributor
Author
|
True, but in the worst case we add the path of python itself at the end, which usually should be there already? |
Member
|
@FliegenKLATSCH Please make it report green on all jobs and I will accept it. |
ssbarnea
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
PATHis not set up correctly and we are invoked via full path, it's likely that ansible itself is just next to us.It's added at the end, so it's only the last resort, if nothing else could be found.