Skip to content

Allow to set max_fail_percentage as templated integer #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssbarnea merged 1 commit into from
Nov 20, 2023
Merged

Allow to set max_fail_percentage as templated integer #3901

ssbarnea merged 1 commit into from
Nov 20, 2023

Conversation

@rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Nov 16, 2023

Recently in a PR, one of my colleagues modified a playbook in this way:

  hosts: all
  strategy: linear
  become: true
  any_errors_fatal: "{{ edpm_any_errors_fatal | default(true) }}"
  max_fail_percentage: "{{ edpm_max_fail_percentage | default(0) }}"
<cut>

but the linter failed with error:

schema[playbook]: $[0].max_fail_percentage '{{ edpm_max_fail_percentage | default(0) }}' is not of type 'number'

Hopefully this should solve the issue.

@rebtoor rebtoor requested a review from a team as a code owner November 16, 2023 15:23
@rebtoor rebtoor requested review from a team, cristianonicolai and shatakshiiii and removed request for a team November 16, 2023 15:23
@rebtoor rebtoor force-pushed the fix/max_fail_percentage_type branch from ac508f4 to f5c97c4 Compare November 16, 2023 15:28
@rebtoor rebtoor mentioned this pull request Nov 17, 2023
Merged
@ssbarnea ssbarnea added the bug label Nov 20, 2023
@ssbarnea ssbarnea merged commit 6e78ac3 into ansible:main Nov 20, 2023
rebtoor added a commit to rebtoor/edpm-ansible that referenced this pull request Nov 29, 2023
@rebtoor
bump version of ansible-lint to v6.22.1
659b8c5 
This is needed to include this [1] pr.

[1] ansible/ansible-lint#3901

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor mentioned this pull request Nov 29, 2023
Merged
rebtoor added a commit to rebtoor/edpm-ansible that referenced this pull request Nov 30, 2023
@rebtoor
bump version of ansible-lint to v6.22.1
2e32f99 
This is needed to include this [1] pr.

[1] ansible/ansible-lint#3901

Signed-off-by: Roberto Alfieri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees

No one assigned

Labels

None yet

Projects

🧰 devtools project board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebtoor @ssbarnea