Skip to content

Conversation

@cidrblock
Copy link
Contributor

@cidrblock cidrblock commented Sep 27, 2023

  • rename _get_matches to get_matches since it is not private and used all over
  • move fix logic into it's own func out of main
  • remove fixed matches from match error list
  • rerun select rules after autofix (currently only yaml)
  • additional debug statements and doc strings as needed
  • swap out `pylint protected-access for ruff SLF001
  • add private option to disable a syntax check rerun during match error pruning after autofix
  • limit autofix to non-skip-list and non-ignored violations

Fixes: #3772
Related: #3775

@cidrblock cidrblock requested a review from a team as a code owner September 27, 2023 17:46
@cidrblock cidrblock requested review from a team, Ruchip16, priyamsahoo and ssbarnea September 27, 2023 17:46
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 17:46 — with GitHub Actions Inactive
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 17:50 — with GitHub Actions Inactive
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 17:55 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug label Sep 27, 2023
@ssbarnea ssbarnea self-assigned this Sep 27, 2023
@ssbarnea ssbarnea temporarily deployed to ack September 27, 2023 19:10 — with GitHub Actions Inactive
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 19:18 — with GitHub Actions Inactive
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 19:18 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack September 27, 2023 19:18 — with GitHub Actions Inactive
@ssbarnea ssbarnea enabled auto-merge (squash) September 27, 2023 19:21
@cidrblock cidrblock temporarily deployed to ack September 27, 2023 19:41 — with GitHub Actions Inactive
@audgirka audgirka temporarily deployed to ack September 28, 2023 11:01 — with GitHub Actions Inactive
@ssbarnea ssbarnea merged commit 0920931 into ansible:main Sep 28, 2023
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.20.0` -> `==6.20.1` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.20.1`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.1)

[Compare Source](ansible/ansible-lint@v6.20.0...v6.20.1)

#### Bugfixes

-   Fix detection of play roles vars missing prefix ([#&#8203;3765](ansible/ansible-lint#3765)) [@&#8203;cavcrosby](https://github.com/cavcrosby)
-   Prune reported errors after autofix ([#&#8203;3774](ansible/ansible-lint#3774)) [@&#8203;cidrblock](https://github.com/cidrblock)
-   `--fix` will now default to `all` ([#&#8203;3777](ansible/ansible-lint#3777)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Avoid false error caused by TypeError with jinja rule ([#&#8203;3773](ansible/ansible-lint#3773)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Sanity Rule Ignore Additions and Updates ([#&#8203;3766](ansible/ansible-lint#3766)) [@&#8203;alisonlhart](https://github.com/alisonlhart)
-   Update rulebook schema (name is now required) ([#&#8203;3776](ansible/ansible-lint#3776)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Expose rules that have autofix capability in docs ([#&#8203;3770](ansible/ansible-lint#3770)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   List all the fixable rules in CLI via `--list-rules` ([#&#8203;3737](ansible/ansible-lint#3737)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Include level in SARIF results ([#&#8203;3758](ansible/ansible-lint#3758)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Meta runtime supported version update ([#&#8203;3755](ansible/ansible-lint#3755)) [@&#8203;alisonlhart](https://github.com/alisonlhart)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/120
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

Post feedback using --fix is confusing

3 participants