-
Notifications
You must be signed in to change notification settings - Fork 713
Ensure that single space between tasks is preserved when using --write #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
35016e7
Ensure that single space between tasks are preserved when using --write
shatakshiiii 36bbe08
Fix for test_formatted_yaml_loader_dumper
shatakshiiii bf5449b
Add tests for formatting task files
shatakshiiii 2305c55
chore: auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 597ef3e
Fix the tests and add more description
shatakshiiii 72975d7
Change test_formatted_task to check single task file, before and afte…
shatakshiiii 8e9e848
Add test for playbook scenario
shatakshiiii 93eb0cb
Changes in the test
shatakshiiii b281894
Improvements in the tests
shatakshiiii ebb7e13
Simplify test
ssbarnea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| - name: Test this playbook | ||
| hosts: all | ||
| tasks: | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
|
|
||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| - name: Test this playbook | ||
| hosts: all | ||
| tasks: | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
|
|
||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| - name: Test this playbook | ||
| hosts: all | ||
| tasks: | ||
| - name: Gather all legacy facts | ||
| cisco.ios.ios_facts: | ||
|
|
||
| - name: Update modification and access time of given file | ||
| ansible.builtin.file: | ||
| path: /etc/some_file | ||
| state: file | ||
| modification_time: now | ||
| access_time: now | ||
|
|
||
| - name: Disable ufw service | ||
| ansible.builtin.service: | ||
| name: ufw | ||
| enabled: false | ||
| state: stopped | ||
| when: '"ufw" in services' | ||
|
|
||
| - name: Remove file (delete file) | ||
| ansible.builtin.file: | ||
| path: /etc/foo.txt | ||
| state: absent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.