Skip to content

Remove G from ruff ignores #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssbarnea merged 5 commits into from
Apr 25, 2023
Merged

Remove G from ruff ignores #3332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4290df0
Remove G from ruff ignores
shatakshiiii Apr 24, 2023
40768f2
Merge branch 'main' into ruff_G
shatakshiiii Apr 24, 2023
a7240c7
fix tests
shatakshiiii Apr 24, 2023
5680bdb
use noqa as other string formatting options are also not supported
shatakshiiii Apr 25, 2023
a332c1b
Merge branch 'main' into ruff_G
shatakshiiii Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ ignore = [
"SIM",
"BLE",
"D",
"G",
"RET",
"EM",
"EXE",
Expand Down
2 changes: 1 addition & 1 deletion src/ansiblelint/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def timed_info(msg: Any, *args: Any) -> Iterator[None]:
yield
finally:
elapsed = time.time() - start
_logger.info(msg + " (%.2fs)", *(*args, elapsed))
_logger.info(msg + " (%.2fs)", *(*args, elapsed)) # noqa: G003


def warn_or_fail(message: str) -> None:
Expand Down
2 changes: 1 addition & 1 deletion src/ansiblelint/skip_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def append_skipped_rules(
yaml_skip = _append_skipped_rules(pyyaml_data, lintable)
except RuntimeError:
# Notify user of skip error, do not stop, do not change exit code
_logger.error("Error trying to append skipped rules", exc_info=True)
_logger.exception("Error trying to append skipped rules")
return pyyaml_data

if not yaml_skip:
Expand Down