Skip to content

Conversation

@TamiTakamiya
Copy link
Contributor

@TamiTakamiya TamiTakamiya commented Nov 4, 2025

Jira Issue: https://issues.redhat.com/browse/AAP-57217

Support allow_write_operations parameter

Description

Support allow_write_operations parameter to enable APIs that can create. change, delete data. See ansible/aap-mcp-server#50 for more information.

Testing

Steps to test

  1. Pull down the PR
  2. Run molecule tests

Scenarios tested

Molecule and manual tests.

Production deployment

  • This code change is ready for production on its own
  • This PR should be released in 2.4 (cherry-pick should be created)
  • This PR should be released in 2.5 (cherry-pick should be created)
  • This PR should be released in 2.6 (cherry-pick should be created)
  • This code change requires the following considerations before going to production:

Note

Introduces an allow_write_operations boolean to AnsibleMCPServer and propagates it across the CRD, samples, docs, Molecule configs/templates, and ConfigMap env.

  • CRD (config/crd/bases/...ansiblemcpservers.yaml):
    • Add spec.allow_write_operations (boolean, default false) with description.
  • Docs (docs/running-on-openshift-cluster.md):
    • Document allow_write_operations and include it in the example AnsibleMCPServer spec.
  • Samples (config/samples/..._ansiblemcpserver.yaml):
    • Include allow_write_operations: false in sample spec.
  • Molecule:
    • Pass through allow_write_operations in molecule.yml inventories and create_mcpserver_instance.yaml.j2.
    • Add allow_write_operations var to default and kind scenarios.
  • ConfigMap (roles/mcpserver/templates/mcpserver.configmap.yaml.j2):
    • Expose ALLOW_WRITE_OPERATIONS env from allow_write_operations.

Written by Cursor Bugbot for commit 647f30f. This will update automatically on new commits. Configure here.

@TamiTakamiya TamiTakamiya marked this pull request as ready for review November 4, 2025 01:51
cursor[bot]

This comment was marked as outdated.

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/allow-write-operations-parameter branch from b6108cb to 679b9e0 Compare November 4, 2025 02:46
@TamiTakamiya TamiTakamiya marked this pull request as draft November 4, 2025 15:11
auto-merge was automatically disabled November 4, 2025 15:11

Pull request was converted to draft

@TamiTakamiya
Copy link
Contributor Author

Convert this back to draft since the default is set to true on OpenShift UI. Looking...

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/allow-write-operations-parameter branch from 679b9e0 to 647f30f Compare November 4, 2025 15:17
@TamiTakamiya TamiTakamiya marked this pull request as ready for review November 4, 2025 15:34
@TamiTakamiya TamiTakamiya merged commit a68334c into main Nov 5, 2025
9 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/allow-write-operations-parameter branch November 5, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants