Skip to content

Conversation

@TamiTakamiya
Copy link
Contributor

@TamiTakamiya TamiTakamiya commented Oct 30, 2025

Jira Issue: https://issues.redhat.com/browse/AAP-57217

Description

Rename AnsibleMCPServer CRD to AnsibleMCPConnect per a recommendation from AAP Operator team for easier testing to enable co-existence of both upstream & downstream CRDs on the same cluster. AnsibleAIConnect CRD already has a different name in downstream (AnsibleLightspeed). We'll implement in the same way.

Testing

Steps to test

Molecule & manual test only

Scenarios tested

Molecule & manual test only

Production deployment

  • This code change is ready for production on its own
  • This PR should be released in 2.4 (cherry-pick should be created)
  • This PR should be released in 2.5 (cherry-pick should be created)
  • This PR should be released in 2.6 (cherry-pick should be created)
  • This code change requires the following considerations before going to production:

Note

Renames the MCP CRD and related resources from AnsibleMCPServer to AnsibleMCPConnect across CRDs, RBAC, watches, docs, samples, and tests, plus bumps the controller image tag.

  • CRDs & API:
    • Replace ansiblemcpservers with ansiblemcpconnects (config/crd/bases/..._ansiblemcpconnects.yaml).
    • Update config/crd/kustomization.yaml and CSV ownership to AnsibleMCPConnect.
  • Operator Wiring:
    • Update watches.yaml to kind: AnsibleMCPConnect with playbooks/ansiblemcpconnect.yml.
    • Adjust RBAC to ansiblemcpconnects resources (config/rbac/role.yaml).
    • Bump controller image tag in config/manager/kustomization.yaml.
  • Samples & Tests:
    • Add/rename sample to config/samples/mcpserver_v1alpha1_ansiblemcpconnect.yaml and kustomization reference.
    • Update Molecule tasks/templates and label selectors to ansiblemcpconnect.
  • Roles:
    • Change default kind and references in roles/mcpserver/* to AnsibleMCPConnect (defaults, tasks, handlers, vars, status, templates).
  • Docs:
    • Revise README.md and docs/running-on-openshift-cluster.md to use AnsibleMCPConnect and update instructions accordingly.

Written by Cursor Bugbot for commit b40ecb0. This will update automatically on new commits. Configure here.

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-57217/rename-mcp-crd branch from 162324b to 3d03579 Compare October 30, 2025 15:26
@TamiTakamiya TamiTakamiya marked this pull request as ready for review October 30, 2025 19:09
@TamiTakamiya TamiTakamiya requested a review from jameswnl October 30, 2025 19:09
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-57217/rename-mcp-crd branch 4 times, most recently from f7dff45 to 8a1f01e Compare November 3, 2025 20:29
jameswnl
jameswnl previously approved these changes Nov 3, 2025
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-57217/rename-mcp-crd branch from 8a1f01e to de3d0a9 Compare November 4, 2025 00:13
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-57217/rename-mcp-crd branch 2 times, most recently from 0e55d6a to 6c63bd3 Compare November 4, 2025 02:48
@jameswnl
Copy link
Contributor

jameswnl commented Nov 4, 2025

cursor review

cursor[bot]

This comment was marked as outdated.

jameswnl
jameswnl previously approved these changes Nov 4, 2025
jameswnl
jameswnl previously approved these changes Nov 5, 2025
@TamiTakamiya TamiTakamiya dismissed jameswnl’s stale review November 5, 2025 03:28

The merge-base changed after approval.

@goneri goneri enabled auto-merge (squash) November 7, 2025 18:43
@goneri goneri merged commit 23ebbf8 into main Nov 7, 2025
9 checks passed
@goneri goneri deleted the TamiTakamiya/AAP-57217/rename-mcp-crd branch November 7, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants