-
Notifications
You must be signed in to change notification settings - Fork 57
Asciidoc conversion of hardening guide changes #3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One main issue and a few suggestions on using the active voice
downstream/modules/aap-hardening/con-create-dedicated-service-account.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-more_compliance-profile-considerations.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-rhel-node-configuration.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-configure-hashicorp-vault.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/ref-install-containerized-deployment.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ianf77 ! I've completed an initial review of this for typos and other small formatting errors. Can you take a look and let me know if you have any questions about my recommendations?
downstream/modules/aap-hardening/ref-sensitive-variables-install-inventory.adoc
Outdated
Show resolved
Hide resolved
downstream/assemblies/aap-hardening/assembly-hardening-aap.adoc
Outdated
Show resolved
Hide resolved
downstream/assemblies/aap-hardening/assembly-hardening-aap.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-hashicorp-vault-external-secrets.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-hashicorp-vault-external-secrets.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-create-dedicated-service-account.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-create-dedicated-service-account.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-create-dedicated-service-account.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/con-more_compliance-profile-considerations.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-create-fapolicyd-rules.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ianf77 ! Few new comments here from my second editorial review. Let me know if you have any questions! :)
downstream/modules/aap-hardening/proc-fapolicyd-permissive-mode.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/ref-install-containerized-deployment.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/ref-install-rpm-deployment.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/ref-sensitive-variables-install-inventory.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/ref-sensitive-variables-install-inventory.adoc
Outdated
Show resolved
Hide resolved
a1eaa71 to
bc27d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added a few minor suggestions but overall it looks good
downstream/assemblies/aap-hardening/assembly-managed-node-configuration.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-create-fapolicyd-rules.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-create-fapolicyd-rules.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-install-containerized-deployment.adoc
Outdated
Show resolved
Hide resolved
downstream/modules/aap-hardening/proc-install-rpm-deployment.adoc
Outdated
Show resolved
Hide resolved
Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
New assembly/files Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Corrected three updated modules Asciidoc conversion of new and revised content for hardening guide v4 https://issues.redhat.com/browse/AAP-48749
Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Added one module and made corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 Please enter the commit message for your changes. Lines starting
Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Edited and renamed modules Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Added variables, renamed module Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Asciidoc conversion of hardening guide changes Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes New assembly/files Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrected three updated modules Asciidoc conversion of new and revised content for hardening guide v4 https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes. Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Added one module and made corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 Please enter the commit message for your changes. Lines starting * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Edited and renamed modules Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Added variables, renamed module Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
* Asciidoc conversion of hardening guide changes Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes New assembly/files Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrected three updated modules Asciidoc conversion of new and revised content for hardening guide v4 https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes. Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Added one module and made corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 Please enter the commit message for your changes. Lines starting * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Correction Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Edited and renamed modules Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Added variables, renamed module Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749 * Asciidoc conversion of hardening guide changes Corrections Asciidoc conversion of new and revised content for hardening guide v4. https://issues.redhat.com/browse/AAP-48749
Asciidoc conversion of new and revised content for hardening guide v4.
https://issues.redhat.com/browse/AAP-48749