Skip to content

Conversation

@ianf77
Copy link
Contributor

@ianf77 ianf77 commented Jul 7, 2025

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

@ianf77 ianf77 added AAP Hardening Content applies to AAP hardening 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Jul 7, 2025
Copy link
Contributor

@g-murray g-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One main issue and a few suggestions on using the active voice

Copy link
Contributor

@emurtoug emurtoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ianf77 ! I've completed an initial review of this for typos and other small formatting errors. Can you take a look and let me know if you have any questions about my recommendations?

Copy link
Contributor

@emurtoug emurtoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ianf77 ! Few new comments here from my second editorial review. Let me know if you have any questions! :)

@ianf77 ianf77 force-pushed the AAP-48749 branch 2 times, most recently from a1eaa71 to bc27d63 Compare July 18, 2025 08:31
Copy link

@jce-redhat jce-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a few minor suggestions but overall it looks good

ianf77 added 13 commits July 22, 2025 08:46
Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
New assembly/files

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Corrected three updated modules

Asciidoc conversion of new and revised content for hardening guide v4

https://issues.redhat.com/browse/AAP-48749
Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Added one module and made corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

Please enter the commit message for your changes. Lines starting
Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Edited and renamed modules

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Added variables, renamed module

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Copy link
Contributor

@emurtoug emurtoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emurtoug emurtoug merged commit 261a009 into ansible:main Jul 23, 2025
ianf77 added a commit to ianf77/aap-docs that referenced this pull request Jul 23, 2025
* Asciidoc conversion of hardening guide changes

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

New assembly/files

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrected three updated modules

Asciidoc conversion of new and revised content for hardening guide v4

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes.

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Added one module and made corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

Please enter the commit message for your changes. Lines starting

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Edited and renamed modules

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Added variables, renamed module

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
g-murray pushed a commit that referenced this pull request Jul 23, 2025
* Asciidoc conversion of hardening guide changes

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

New assembly/files

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrected three updated modules

Asciidoc conversion of new and revised content for hardening guide v4

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes.

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Added one module and made corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

Please enter the commit message for your changes. Lines starting

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Correction

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Edited and renamed modules

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Added variables, renamed module

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749

* Asciidoc conversion of hardening guide changes

Corrections

Asciidoc conversion of new and revised content for hardening guide v4.

https://issues.redhat.com/browse/AAP-48749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.5 Content applies to AAP 2.5 AAP Hardening Content applies to AAP hardening Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants