Skip to content

Update chapter on metric-utility #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 28, 2025
Merged

Update chapter on metric-utility #3322

merged 9 commits into from
Apr 28, 2025

Conversation

@ianf77
Copy link
Contributor

@ianf77 ianf77 commented Apr 24, 2025

New modules added. +new content

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

@ianf77 ianf77 added Controller Content applies to automation controller 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Apr 24, 2025
@ianf77 ianf77 requested a review from michellemacrh April 25, 2025 09:20
ianf77 added 3 commits April 28, 2025 08:25
@ianf77
Update chapter on metric-utility
8435d7b 
New modules added. +new content

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metrics-utility
9e467c9 
Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metric-utility
0abc9e2 
Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
michellemacrh
michellemacrh reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@michellemacrh michellemacrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed - I noted a few build/formatting issues when building the docs locally and I may not have caught them all so would recommend doing a build to ensure everything renders correctly :)

ianf77 added 4 commits April 28, 2025 11:57
@ianf77
Update chapter on metrics-utility
b30edfc 
Corrections from review

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metrics-utilities
9d7dfc4 
Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metrics-utility
7a8c1c9 
Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metrics-utility
e8b45a9 
Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
g-murray
g-murray reviewed Apr 28, 2025
View reviewed changes
ianf77 added 2 commits April 28, 2025 16:10
@ianf77
Update chapter on metrics-utility
7f39301 
Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
@ianf77
Update chapter on metrics-utility
a3a8fab 
Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
g-murray
g-murray approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@g-murray g-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-murray g-murray merged commit 0b8a8b1 into ansible:main Apr 28, 2025
@ariordan-redhat ariordan-redhat added the Delay backport Content can't be backported to a release branch yet label Apr 29, 2025
ariordan-redhat pushed a commit to ariordan-redhat/aap-docs that referenced this pull request May 2, 2025
@ianf77 @ariordan-redhat
Update chapter on metric-utility (ansible#3322)
800f681 
* Update chapter on metric-utility

New modules added. +new content

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metric-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections from review

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utilities

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185
ianf77 added a commit that referenced this pull request May 2, 2025
@ariordan-redhat @ianf77
2.5 Update chapter on metric-utility (#3322) (#3383)
3b9b83a 
* Update chapter on metric-utility (#3322)

* Update chapter on metric-utility

New modules added. +new content

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metric-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections from review

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utilities

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Corrections

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Update chapter on metrics-utility

Correction

Asciidoc conversion for metrics-utilities docs (Ch 11 in configuring automation execution)

https://issues.redhat.com/browse/AAP-44185

* Fix typo

---------

Co-authored-by: Ian Fowler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michellemacrh michellemacrh michellemacrh left review comments

@g-murray g-murray g-murray approved these changes

Assignees

No one assigned

Labels

2.5 Content applies to AAP 2.5 Controller Content applies to automation controller Delay backport Content can't be backported to a release branch yet Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ianf77 @michellemacrh @g-murray @ariordan-redhat