Skip to content

Conversation

@TheYorkshireDev
Copy link
Contributor

@TheYorkshireDev TheYorkshireDev commented Jul 30, 2025

Summary of changes

As outlined in this ticket (#342) forward slash is not supported for prefixes because of a conflict with sed. Forward slash in particular is common in tagging especially in a monorepo with multiple deployable entities.

I've updated the sed command to use semicolon ; as a separator to support the large majority of use cases.

In this change I have also introduced a new test framework for the project BATs to support testing this change. The penultimate commit pushed the tests that verified that the / was not supported in a prefix, and the last commit actually fixed it (making the tests pass).

To support testing these particular changes and to avoid too much setup, I've passed in the DRY_RUN flag which allows us to test the functionality we need, however in future tests (if you decide to adopt this approach) it can be omited and committed to a repo.

Breaking Changes

Do any of the included changes break current behaviour or configuration?

  • NO

How changes have been tested

List any unknowns

@TheYorkshireDev TheYorkshireDev marked this pull request as ready for review July 30, 2025 08:29
@TheYorkshireDev TheYorkshireDev changed the title Support Escapable Characters in Prefix Support Escapable Characters in Prefix With BATs Testing Jul 30, 2025
@TheYorkshireDev
Copy link
Contributor Author

@anothrNick When you get the chance could you take a look please.

@ChintanRaval
Copy link

@anothrNick Thanks for approving this. When you get a chance, could you please also merge and release this change?

@TheYorkshireDev
Copy link
Contributor Author

@anothrNick Do you have the ability to approve the workflows for this PR, or can you point us in the direction of a maintainer who can please?

@anothrNick anothrNick merged commit 4ed4496 into anothrNick:master Aug 22, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants