feat(tui): Ability to Toggle LSP Diagnostics #7276
Open
+335
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
- add ability to toggle lsp diagnostics - show LSP diagnostics status in sidebar - regenerate type info to include lsp_diagnostics flag - add tests for write & edit tool depending on diagnostics state - add autocomplete for lsp diagnostics toggle slash cmd
…th limit error in server.ts lsp_diagnostics defaults to "true"
itsrainingmani
force-pushed
the
toggle-lsp
branch
from
ee1d4e5 to
c607677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6692
edit&writetools skip fetching and adding LSP diagnostics to the modelScreenshots
Command Palette
Slash Command
Toast + Sidebar
Output Comparison
# LSP Diagnostics enabled DEBUG +0ms service=lsp fileCount=1 totalDiagnostics=158 diagnostics fetched DEBUG +0ms service=tool.write diagnostics_enabled=true filepath=/tmp/lsp-stress-test.ts diagnosticFileCount=1 tool.write diagnostics check This file has errors, please fix <file_diagnostics> ERROR [4:7] Type 'number' is not assignable to type 'string'. ERROR [5:7] Type 'string' is not assignable to type 'number'. ERROR [6:7] Type 'string' is not assignable to type 'boolean'. ERROR [7:24] Type 'string' is not assignable to type 'number'. ERROR [7:29] Type 'string' is not assignable to type 'number'. ERROR [7:34] Type 'string' is not assignable to type 'number'. ERROR [8:30] Type 'string' is not assignable to type 'number'. ERROR [14:5] Argument of type 'string' is not assignable to parameter of type 'number'. ... and 67 more </file_diagnostics> tool.write diagnostic outputvs
# LSP Diagnostics Disabled DEBUG +0ms service=lsp enabled=false diagnosticsStatus called DEBUG +0ms service=tool.write diagnostics_enabled=false filepath=/tmp/lsp-stress-test-common.ts diagnosticFileCount=0 tool.write diagnostics check DEBUG +0ms service=tool.write diagnostics={} output= tool.write diagnostic output