feat(opencode): add LSP timeout configuration#21006
Open
ririnto wants to merge 1 commit intoanomalyco:devfrom
Open
feat(opencode): add LSP timeout configuration#21006ririnto wants to merge 1 commit intoanomalyco:devfrom
ririnto wants to merge 1 commit intoanomalyco:devfrom
Conversation
- Allow configured LSP entries to override initialize and diagnostics timeouts. - Document the behavior and lock in the default and override paths with tests.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, I found a potentially related PR: Related PR:
Please verify if PR #13332 is already merged or closed, and whether the current PR (21006) is a reimplementation or enhancement of that work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related: #13328
Type of change
What does this PR do?
This PR adds per-server timeout configuration for configured LSP entries.
It introduces separate timeout settings for the two existing timeout paths:
timeout.startupfor the LSPinitializerequesttimeout.diagnosticsfor the diagnostics wait pathThis is related work for #13328, which calls out the lack of a user escape hatch for heavy LSP servers. It also follows the per-server configuration direction proposed in #6997 while keeping the scope limited to configured entries and the two existing timeout paths.
How did you verify your code works?
bun test test/lsp/client.test.ts test/config/config.test.tsinpackages/opencodebun typecheckinpackages/opencodeScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist