Skip to content

fix: support ACP question prompts via extMethod#20016

Closed
hikaruczl wants to merge 1 commit intoanomalyco:devfrom
hikaruczl:feat/acp-question
Closed

fix: support ACP question prompts via extMethod#20016
hikaruczl wants to merge 1 commit intoanomalyco:devfrom
hikaruczl:feat/acp-question

Conversation

@hikaruczl
Copy link
Copy Markdown

Summary

  • gate ACP question support on both OPENCODE_ENABLE_QUESTION_TOOL and a client-advertised opencode/question capability
  • bridge internal question.asked events to ACP clients over extMethod("opencode/question", ...) and reply/reject through the existing question API
  • document the extension contract and cover the new flow in ACP event-subscription tests

Validation

  • bun test ./test/acp/event-subscription.test.ts
  • bun test ./test/tool/question.test.ts
  • bun test ./test/acp/agent-interface.test.ts
  • bun run typecheck

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my searches, I found one PR that is closely related to the current PR #20016:

Related PR:

The other PRs found (#13750, #17921, #13974) are tangentially related to question tool handling but address different aspects (enabling the tool, handling question.asked events, and preventing hangs).

@hikaruczl
Copy link
Copy Markdown
Author

Closing this fork PR; opening the same changes against sst/opencode instead.

@hikaruczl hikaruczl closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours. needs:issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant