fix: only require TodoWrite when it is actually available#19057
Open
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Open
fix: only require TodoWrite when it is actually available#19057Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: PR #18202 - "fix(task): preserve subagent todo permissions"
The current PR (19057) appears to be addressing a newer/refined version of this issue, closing #18061, but PR #18202 is worth reviewing to ensure there's no overlap or conflict. |
ac6efa7 to
dc14a84
Compare
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18061
Type of change
What does this PR do?
This fixes a prompt/tooling mismatch around TodoWrite.
Before this change, the provider prompt could still tell the model to use TodoWrite even when
todowritewas not actually available.This change makes TodoWrite-specific prompt instructions conditional on the resolved tool set, so they are only included when
todowriteis available.This should work because the prompt now matches the tools the model can actually use.
How did you verify your code works?
I ran:
bun test test/session/system.test.tsfrompackages/opencodeI also checked:
git diff --checkScreenshots / recordings
N/A
Checklist