Skip to content

effectify Pty service#18319

Closed
kitlangton wants to merge 3 commits intodevfrom
kit/effectify-pty
Closed

effectify Pty service#18319
kitlangton wants to merge 3 commits intodevfrom
kit/effectify-pty

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • Migrate Pty from Instance.state() to Effect service pattern
  • State uses Map<PtyID, ActiveSession> in layer closure
  • Instance.bind replaced by InstanceContext closure capture
  • Effect.addFinalizer handles process cleanup on instance disposal
  • Sync facades (list, get, resize, write, connect) use runSyncInstance
  • Async facades (create, update, remove) use runPromiseInstance
  • Adds runSyncInstance helper to runtime.ts

Test plan

  • bun run typecheck passes
  • Verify PTY creation/connection works in TUI

@kitlangton kitlangton closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant