Skip to content

fix(provider): only set thinkingConfig for models with reasoning capability #18283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 2 commits into from
Mar 21, 2026
+73 −5
Merged

fix(provider): only set thinkingConfig for models with reasoning capability #18283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39b1e8
fix(provider): only set thinkingConfig for models with reasoning capa…
Protocol-zero-0 Mar 19, 2026
14e52de
test(provider): cover google thinkingConfig capability gating
Protocol-zero-0 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/opencode/src/provider/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,11 +755,13 @@ export namespace ProviderTransform {
}

if (input.model.api.npm === "@ai-sdk/google" || input.model.api.npm === "@ai-sdk/google-vertex") {
result["thinkingConfig"] = {
includeThoughts: true,
}
if (input.model.api.id.includes("gemini-3")) {
result["thinkingConfig"]["thinkingLevel"] = "high"
if (input.model.capabilities.reasoning) {
result["thinkingConfig"] = {
includeThoughts: true,
}
if (input.model.api.id.includes("gemini-3")) {
result["thinkingConfig"]["thinkingLevel"] = "high"
}
}
Comment on lines 757 to 765
Copy link

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit coverage for this new gating to prevent regressions: ProviderTransform.options should NOT set thinkingConfig for Google/Vertex models when model.capabilities.reasoning is false (e.g. gemini-2.0-flash), and should set it when reasoning is true. There are existing ProviderTransform.options tests in packages/opencode/test/provider/transform.test.ts, but none currently assert this Google/Vertex behavior.

Copilot uses AI. Check for mistakes.
}

Expand Down
66 changes: 66 additions & 0 deletions packages/opencode/test/provider/transform.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,72 @@ describe("ProviderTransform.options - setCacheKey", () => {
})
})

describe("ProviderTransform.options - google thinkingConfig gating", () => {
const sessionID = "test-session-123"

const createGoogleModel = (reasoning: boolean, npm: "@ai-sdk/google" | "@ai-sdk/google-vertex") =>
({
id: `${npm === "@ai-sdk/google" ? "google" : "google-vertex"}/gemini-2.0-flash`,
providerID: npm === "@ai-sdk/google" ? "google" : "google-vertex",
api: {
id: "gemini-2.0-flash",
url: npm === "@ai-sdk/google" ? "https://generativelanguage.googleapis.com" : "https://vertexai.googleapis.com",
npm,
},
name: "Gemini 2.0 Flash",
capabilities: {
temperature: true,
reasoning,
attachment: true,
toolcall: true,
input: { text: true, audio: false, image: true, video: false, pdf: true },
output: { text: true, audio: false, image: false, video: false, pdf: false },
interleaved: false,
},
cost: {
input: 0.001,
output: 0.002,
cache: { read: 0.0001, write: 0.0002 },
},
limit: {
context: 1_000_000,
output: 8192,
},
status: "active",
options: {},
headers: {},
}) as any

test("does not set thinkingConfig for google models without reasoning capability", () => {
const result = ProviderTransform.options({
model: createGoogleModel(false, "@ai-sdk/google"),
sessionID,
providerOptions: {},
})
expect(result.thinkingConfig).toBeUndefined()
})

test("sets thinkingConfig for google models with reasoning capability", () => {
const result = ProviderTransform.options({
model: createGoogleModel(true, "@ai-sdk/google"),
sessionID,
providerOptions: {},
})
expect(result.thinkingConfig).toEqual({
includeThoughts: true,
})
})

test("does not set thinkingConfig for vertex models without reasoning capability", () => {
const result = ProviderTransform.options({
model: createGoogleModel(false, "@ai-sdk/google-vertex"),
sessionID,
providerOptions: {},
})
expect(result.thinkingConfig).toBeUndefined()
})
})

describe("ProviderTransform.options - gpt-5 textVerbosity", () => {
const sessionID = "test-session-123"

Expand Down
Loading