fix(opencode): add JSON validation for tool call arguments#17818
Open
LehaoLin wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): add JSON validation for tool call arguments#17818LehaoLin wants to merge 2 commits intoanomalyco:devfrom
LehaoLin wants to merge 2 commits intoanomalyco:devfrom
Conversation
Strip XML artifacts and validate JSON before emitting tool-call events - Fix non-streaming mode (doGenerate) - Fix streaming mode (flush) - Strip tool_call XML tags from providers like SiliconFlow - Validate JSON with isParsableJson before use - Skip invalid tool calls with warning Fixes anomalyco#17750
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR: PR #17339: fix(opencode): handle repeated full streamed tool-call arguments Why it might be related: Both PRs address tool call argument handling. PR #17339 deals with repeated full streamed tool-call arguments, which could be related to the streaming mode JSON validation fix in PR #17818. However, these appear to be addressing different specific issues - #17339 focuses on repeated arguments in streaming, while #17818 focuses on XML artifact removal and JSON validation. No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17750
Type of change
What does this PR do?
Problem: SiliconFlow Qwen3-8B model returns tool call arguments with XML tags that break JSON parsing.
Solution: Strip XML artifacts and validate JSON before emitting tool-call events in both streaming and non-streaming modes.
How did you verify your code works?
Checklist