fix(desktop-electron): sanitize CLI command args to prevent OS command injection#17346
Closed
kvenux wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(desktop-electron): sanitize CLI command args to prevent OS command injection#17346kvenux wants to merge 1 commit intoanomalyco:devfrom
kvenux wants to merge 1 commit intoanomalyco:devfrom
Conversation
… (CWE-78) Change spawnCommand/buildCommand to accept string[] instead of string, and shellEscape each argument individually before interpolating into shell commands. This prevents injection via hostname, port, or other user-controllable parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Closing: after deeper analysis, |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17345
Type of change
What does this PR do?
spawnCommandandbuildCommandinpackages/desktop-electron/src/main/cli.tsaccepted a raw string for CLI arguments and interpolated it directly into shell commands (bash -c, WSL script). If any parameter likehostnamecontained shell metacharacters (;,$(), backticks), they would be executed by the shell.Changed both functions to accept
string[]instead ofstring. Each argument is now individuallyshellEscape()d before interpolation into shell commands. Windows direct mode passes the array directly without shell involvement.How did you verify your code works?
Added
cli.security.test.tswith 13 test cases covering:;,|,&&$()and backticksAll 13 tests pass.
Screenshots / recordings
Not a UI change.
Checklist