fix(tui): fix system theme contrast with transparency#13239
Closed
akronb wants to merge 17 commits intoanomalyco:devfrom
Closed
fix(tui): fix system theme contrast with transparency#13239akronb wants to merge 17 commits intoanomalyco:devfrom
akronb wants to merge 17 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
akronb
force-pushed
the
fix-transparency
branch
from
7981bdd to
84889ab
Compare
akronb
force-pushed
the
fix-transparency
branch
from
c980d99 to
be685ef
Compare
akronb
force-pushed
the
fix-transparency
branch
from
be685ef to
5f86dac
Compare
opencode-agent
bot
force-pushed
the
dev
branch
from
46f258d to
7a42ecd
Compare
6 tasks
|
I used these changes on top of |
Collaborator
|
@akronb is this what you mentioned on opentui as well and would this be fixed with opentui improvement? |
Contributor
Author
|
@kommander nope, that’s a different issue. It fixes visual bugs after The issue for the opentui thing is #13363. I checked it out, and it needs a small hook check to trigger a background re-render in the app root container. |
6 tasks
Contributor
Author
|
Fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12184
Fixes #13363
PR #8467 set
background: transparentfor the system theme to support terminal transparency. This caused rendering and contrast issues in parts of the UI, especially on light themes.This PR makes only the app background transparent, ensuring that all other uses of
theme.backgroundremain readable. It also adds acreateEffecthook withrenderer.setBackgroundColorto fix the alpha blending issue.