Skip to content

Conversation

@IdrisGit
Copy link
Contributor

What does this PR do?

cleanup a couple of experimental keys (hook and chatMaxRetries) from the config that are not used anywhere.

How did you verify your code works?

  1. grepped through the codebase to find if these keys are used anywhere
  2. the typecheck would have failed after generating new type gen, if they were used anywhere in the codebase but it didn't fail (screen record below).
cleanup-exprimental-config.mp4

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@IdrisGit IdrisGit force-pushed the chore-cleanup-experimental-config-keys branch from 005478d to 40308c4 Compare January 29, 2026 20:46
@rekram1-node
Copy link
Collaborator

Once ci passes I can merge

@IdrisGit
Copy link
Contributor Author

@rekram1-node can you please help me with the issue (screenshot below)

is it an issue with the workflow or do I need update some settings in my fork? because the generate step runs fine, it's the commit and push which is failing.

image

@IdrisGit
Copy link
Contributor Author

Also I am confused, why does the action need to push changes to my fork?

I am guessing it's an artifact of the workflow being run during release earlier but now it's added to the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants