Skip to content

Conversation

@murisi
Copy link
Collaborator

@murisi murisi commented Feb 28, 2025

Describe your changes

An attempt to reduce the amount of screens clicked through on the hardware wallet for shielded/unshielding transactions. This is done by displaying the payment address of a note as the sender (similar to what the Zcash Ledger app does) instead of the extended full viewing key that owns it. This reduces the number of screens required to display a sender from 8 to 3. I.e. there's now 5 less screens to click though, which reduces the amount of time required to sign a shielded transaction once the display lag is considered. Alternative options were considered like displaying just a full viewing key or an incoming viewing key instead of the extended full viewing key, but these do not already have bech32 encodings in Namada nor can they be used in any of the existing interfaces. See attached what the new test vectors would look like: testvecs-fmted.json.gz and testdbgs.txt.gz.

This PR depends upon namada-net/masp#92 to obtain the payment addresses of transaction input notes.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi added the MASP label Feb 28, 2025
@murisi murisi requested a review from tzemanovic February 28, 2025 10:37
@murisi murisi added the do-not-merge Do not merge for now label Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (619f79c) to head (5554ab4).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4436      +/-   ##
==========================================
- Coverage   74.50%   74.49%   -0.01%     
==========================================
  Files         339      339              
  Lines      110638   110641       +3     
==========================================
- Hits        82432    82425       -7     
- Misses      28206    28216      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 28, 2025
Cargo.toml Outdated
madato = "0.7"
masp_primitives = { version = "1.2" }
masp_proofs = { version = "1.2", default-features = false, features = ["local-prover"] }
masp_primitives = { git = "https://github.com/anoma/masp", rev = "badb4b00e2ea358f4051069c7d0ab66ff76b694c" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make a release before merging

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ready to use in version 1.3.0

@murisi murisi force-pushed the murisi/compress-hw-displays branch from 9b44d85 to a3e2cbc Compare March 8, 2025 19:21
@tzemanovic tzemanovic removed the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge for now MASP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants