-
Notifications
You must be signed in to change notification settings - Fork 1k
Display payment addresses instead of extended full viewing keys in test vectors #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
- Coverage 74.50% 74.49% -0.01%
==========================================
Files 339 339
Lines 110638 110641 +3
==========================================
- Hits 82432 82425 -7
- Misses 28206 28216 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cargo.toml
Outdated
| madato = "0.7" | ||
| masp_primitives = { version = "1.2" } | ||
| masp_proofs = { version = "1.2", default-features = false, features = ["local-prover"] } | ||
| masp_primitives = { git = "https://github.com/anoma/masp", rev = "badb4b00e2ea358f4051069c7d0ab66ff76b694c" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make a release before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ready to use in version 1.3.0
9b44d85 to
a3e2cbc
Compare
…enders in test vectors.
a3e2cbc to
5554ab4
Compare
Describe your changes
An attempt to reduce the amount of screens clicked through on the hardware wallet for shielded/unshielding transactions. This is done by displaying the payment address of a note as the sender (similar to what the Zcash Ledger app does) instead of the extended full viewing key that owns it. This reduces the number of screens required to display a sender from 8 to 3. I.e. there's now 5 less screens to click though, which reduces the amount of time required to sign a shielded transaction once the display lag is considered. Alternative options were considered like displaying just a full viewing key or an incoming viewing key instead of the extended full viewing key, but these do not already have bech32 encodings in Namada nor can they be used in any of the existing interfaces. See attached what the new test vectors would look like: testvecs-fmted.json.gz and testdbgs.txt.gz.
This PR depends upon namada-net/masp#92 to obtain the payment addresses of transaction input notes.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo