Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2025

Describe your changes

This PR was obtained by rebasing #4436 on main (ff17969). An attempt to reduce the amount of screens clicked through on the hardware wallet for shielded/unshielding transactions. This is done by displaying the payment address of a note as the sender (similar to what the Zcash Ledger app does) instead of the extended full viewing key that owns it. This reduces the number of screens required to display a sender from 8 to 3. I.e. there's now 5 less screens to click though, which reduces the amount of time required to sign a shielded transaction once the display lag is considered. Alternative options were considered like displaying just a full viewing key or an incoming viewing key instead of the extended full viewing key, but these do not already have bech32 encodings in Namada nor can they be used in any of the existing interfaces. See attached what the new test vectors would look like: testvecs-fmted.json.gz and testdbgs.txt.gz.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4700 done by [Mergify](https://mergify.com).

murisi added 3 commits June 25, 2025 15:31
…enders in test vectors.

(cherry picked from commit 45d7f2e)
(cherry picked from commit b3bcc28)
(cherry picked from commit 9518da4)
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (bf3ca44) to head (5633720).
Report is 5 commits behind head on maint-libs-0.150.

Additional details and impacted files
@@           Coverage Diff            @@
##   maint-libs-0.150   #4715   +/-   ##
========================================
========================================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot merged commit 9624ca6 into maint-libs-0.150 Jun 30, 2025
24 of 25 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.150/pr-4700 branch June 30, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants