Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Oct 16, 2024

Describe your changes

  • Adds property tests for malleability attacks on transactions
  • Improves test_wrapper_unknown_address
  • Removes old references to encrypted/decrypted txs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

grarco added a commit that referenced this pull request Oct 18, 2024
@grarco grarco force-pushed the grarco/test-malleability-attacks branch from d4e741b to 39972d5 Compare October 18, 2024 17:09
@grarco grarco marked this pull request as ready for review October 18, 2024 17:09
@grarco grarco added the testing label Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (3a68288) to head (2a98138).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/shell/process_proposal.rs 88.23% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
+ Coverage   74.09%   74.25%   +0.15%     
==========================================
  Files         341      341              
  Lines      107204   107271      +67     
==========================================
+ Hits        79431    79650     +219     
+ Misses      27773    27621     -152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco requested a review from tzemanovic October 18, 2024 17:55
grarco added a commit that referenced this pull request Nov 5, 2024
@grarco grarco force-pushed the grarco/test-malleability-attacks branch from 39972d5 to da127a4 Compare November 5, 2024 15:10
@brentstone
Copy link
Collaborator

What is the status of this?

@grarco grarco force-pushed the grarco/test-malleability-attacks branch from da127a4 to 2a98138 Compare November 15, 2024 09:46
@grarco
Copy link
Collaborator Author

grarco commented Nov 15, 2024

What is the status of this?

I believe it's ready for merge

@grarco grarco added backport-45 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Nov 15, 2024
mergify bot added a commit that referenced this pull request Nov 15, 2024
@mergify mergify bot merged commit 47fc912 into main Nov 15, 2024
24 checks passed
@mergify mergify bot deleted the grarco/test-malleability-attacks branch November 15, 2024 15:32
mergify bot pushed a commit that referenced this pull request Nov 15, 2024
(cherry picked from commit 2a98138)
mergify bot added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants