Ethereum bridge 😨 #1674
Closed
Ethereum bridge 😨 #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/ethbridge/amounts+ethbridge
branch
from
c422160 to
c6712da
Compare
Namada 0.18.1 is a patch release that addresses transaction format changes and minor ledger storage improvements. * tag 'v0.18.1': Namada 0.18.1 added chagelog Added changelog entry. clippy, fmt Simplified the reveal PK transaction construction flow. Factored chain_id reading from submit functions. Allow Tx builders to take verification keys. Increased usage of PublicKeys relative to SecretKeys in tx construction. Only reveal a public key when the signer is an implicit address. Now only use TxBroadcastData::Wrapper for non dry runs. Now update proof of work solution in transaction header. Separating out the reveal PK transaction construction. Separate transaction building from signing from submission. Removed unnecessary header updates for dry runs. clippy fmt and clippy Update .github/PULL_REQUEST_TEMPLATE/new_topic.md hopefully fixes init_network Added a changelog entry. Stop encrypting transactions in tests. Disable encrypting transactions when sending. git: added topic PR template fix: increase the genesis parameter changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments fix `unclog release` command Added changelog entry. Fixed processing of code inside init-proposal transactions. changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments Update build_network.sh Added changelog entry. [fix]: CMT_LOG_LEVEL is now correct, not TM_LOG_LEVEL ledger/db: ensure that prefix iter only matches full key segments fix annoying error on line 69 [fix]: Fix failing test-wasm by adding code section and also signing over that. docs: update rust-analyzer clippy override Expanded validate_header to check for signature over all sections, and renamed it to validate_tx. Make the signature section unmalleable. VPs now check that code and data are signed together. Fixed clippy and formatting issues. Fixed the tests involving transaction signing. Now sign over all sections in transactions. Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view. Now moving proposal code into extra section. Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
brentstone
added a commit
that referenced
this pull request
Jul 6, 2023
* tiago/ethbridge/amounts+ethbridge: (2927 commits) Fix unit tests Update Cargo lock files Fix outstanding compiler errors Fix adding new content to the Bridge pool Run make fmt Remove log lines not printed by cometbft anymore New test: test_mempool_eth_events_vext_data_mismatch Fix misspell of workspace in Cargo manifest file Cargo doc fixes Do not unwrap vext deserialization failures Move module docs Inherit workspace fields in the Ethereum bridge crate Update Cargo lock files Misc fixes Add hasher as a param to `Signed` Make the hasher a type param of sig schemes Add a couple of new lines Only enable wasmtimer in wasm builds refactor: replace wasm-timer with wasmtimer to support web worker context fix: namada to compile to wasm32-unknown-unknown Purge rust_decimal Fix e2e test genesis file Misc yuji fixes Fixes to the NAM addresses Fix Ethereum bridge unit tests [fix]: Fixed some unit tests Fix compiler errors Fix remaining unit tests Replace nam() with native token addr in storage Use generated fns to define Eth bridge param predicates Export generated macro fns Move Ethereum param keys Misc unit test fixes Fix StorageKeys derives Generate key helper fns Fix tx expiration test Fix eth protocol tx serialization Make fmt Replace KeySeg impl for Epoch with the one from main Compilation fixes Fix IBC test Temporarily disable Ethereum bridge e2e tests Remove non-sensical e2e tests Fix Bridge pool recommendations Add `proceed` method to control flows WIP: Fix e2e::eth_bridge_tests::test_bridge_pool_e2e Fix e2e::ledger_tests::test_bond_queries Fix e2e::ledger_tests::test_genesis_validators Remove masp proofs from wasm Display a contextual error msg in some CLI cmds Changes from #1550 Allow Eth oracle to keep running in tests on some failures Fix the build Format Clippy Add Cargo lock files Hopefully finish fixing apps WIP Temporarily disable bridge pool recommendations Remove heap allocs from uint negation WIP: Fixing amounts WIP fixing compile errors from the merge Erase Eth RPC address from SDK types Re-order instant query since a tokio watch chan borrow can block User shutdown is not a fatal error Implement RpcClient with ethers Start removing web30 dep from apps Remove web30 deps from Cargo files Update wasm Cargo lock files Remove comments Fix CLI args Purge weird test cfg-flags for the Ethereum oracle Add generic geth rpc client for the eth oracle Remove needless lifetimes Remove needless heap alloc Remove ShouldRelay tokio dep Remove tokio's LocalSet dep in shared Refactor relayer to use generic ethers middleware Remove web30 dep on shared Refactor wasm compilation cache sleep to use ExponentialBackoff Allow ExponentialBackoff to capture env Add map to sleep strategy Remove async-std from shared Remove timeout defaults Remove sketchy code from timeouts Refactor wait_until_node_is_synched Refactor fixes Refactor sleep strategy to allow custom states Refactor SleepStrategy to include retry method Add error bounds to client Remove unused query_tx_status in apps Refactor query_tx_status Add new Halt method Do not ignore control flows in the CLI Fix tests ending prematurely Replace test oracle command sender Do not block on signal receiving Import build devnet script from main Fix `make build-debug` Update Cargo lock files in wasms ...
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(except draft)
this is just here for the sake of testing CI