Skip to content

Conversation

@crisbeto
Copy link
Member

Makes the mat-paginator a block-level element by default, instead of inline.

Fixes #8454.

Makes the `mat-paginator` a block-level element by default, instead of inline.

Fixes angular#8454.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 15, 2017
@andrewseguin
Copy link
Contributor

My understanding was that we didn't want to put display styles on outer component containers. Have we done this yet with any other components?

@crisbeto
Copy link
Member Author

AFAIK the rule is that we don’t do flexbox and margins on the outer component.

@willshowell
Copy link
Contributor

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 4, 2017
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@andrewseguin andrewseguin merged commit bd50fa6 into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
Makes the `mat-paginator` a block-level element by default, instead of inline.

Fixes angular#8454.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The style property 'display' of the mat-paginator component should set to 'display: block' by default

4 participants