Skip to content

feat(slider): support specifying tabindex #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2017
Merged

feat(slider): support specifying tabindex #7848

merged 1 commit into from
Nov 20, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 17, 2017

  • Provides a consistent API for developers to specify the tabIndex for the slider
  • Disabled sliders are no longer tabbable (for accessibility reasons)

@devversion devversion requested a review from mmalerba as a code owner October 17, 2017 13:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 17, 2017
@devversion devversion added the Accessibility This issue is related to accessibility (a11y) label Oct 17, 2017
@devversion devversion force-pushed the feat/slider-specify-tabindex branch from 8c862ad to 63ca0bd Compare November 19, 2017 08:47
@devversion
feat(slider): support specifying tabindex
39be226 
* Provides a consistent API for developers to specify the tabIndex for the slider
* Disabled sliders are no longer tabbable (for accessibility reasons)
@devversion devversion force-pushed the feat/slider-specify-tabindex branch from 63ca0bd to 39be226 Compare November 19, 2017 10:27
@jelbourn jelbourn merged commit 8e9dade into angular:master Nov 20, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @mmalerba @jelbourn @googlebot