Skip to content

Conversation

@wagnermaciel
Copy link
Contributor

  • Adds the underlying WAI-ARIA menu, menubar, and menuitem UI patterns.
  • Implements the ngMenu, ngMenuBar, ngMenuItem, and ngMenuTrigger directives.
  • Introduces a set of examples demonstrating common use cases, including a menubar, a
    standalone menu, a context menu, and a menu attached to a trigger.

@wagnermaciel wagnermaciel requested a review from a team as a code owner October 14, 2025 22:49
@wagnermaciel wagnermaciel requested review from adolgachev and ok7sai and removed request for a team October 14, 2025 22:49
@wagnermaciel wagnermaciel added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Oct 14, 2025
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Deployed dev-app for 21a3d75 to: https://ng-dev-previews-comp--pr-angular-components-32080-dev-vqxm81d2.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@wagnermaciel wagnermaciel force-pushed the aria-menu branch 2 times, most recently from 46848d7 to 12f3d89 Compare October 15, 2025 21:29
readonly submenu = input<Menu<V> | undefined>(undefined);

/** The unique ID of the menu. */
readonly id = input<string>(Math.random().toString(36).substring(2, 10));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the new ID strategy?

}

/** Handles mouseover events for the menu. */
onMouseOver(event: MouseEvent) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this handles pointer event instead?

@angular-robot angular-robot bot requested a review from adolgachev October 20, 2025 16:50
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 20, 2025
* Adds the initial implementation of the WAI-ARIA menu, menubar, and menuitem patterns. This
includes the basic behaviors for keyboard navigation, opening and closing submenus, and
typeahead support.
* This also introduces a 'focusElement' option to the list navigation behaviors to allow for
moving the active item without focusing it.
* Adds the initial implementation of the 'ngMenu', 'ngMenuBar', 'ngMenuItem', and
'ngMenuTrigger' directives built on top of the menu UI patterns.
* Adds four examples for the new ARIA menu directives:
  - A menubar example demonstrating a typical application menu.
  - A menu trigger example showing a simple icon button that opens a menu.
  - A standalone menu example.
  - A context menu example that opens on right-click.
* Also includes a set of simple wrapper directives to apply basic popover styles and behavior
to the examples.
@wagnermaciel wagnermaciel removed the request for review from adolgachev October 20, 2025 17:29
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 20, 2025
@wagnermaciel wagnermaciel merged commit f9d3cde into angular:main Oct 20, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants