Skip to content

fix(material-date-fns-adapter): parse time string containing only hours #31978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix(material-date-fns-adapter): parse time string containing only hours #31978

merged 1 commit into from
Oct 2, 2025

Conversation

@lekhmanrus
Copy link
Contributor

@lekhmanrus lekhmanrus commented Oct 2, 2025 •
edited
Loading

Add test cases for parse time string containing only hours to:

  • material-date-fns-adapter
  • material-luxon-adapter
  • material-moment-adapter

Fix material-date-fns-adapter parseTime() method and refactor a bit to be able to reuse the code (_parse()).

Close #31837

@lekhmanrus lekhmanrus requested a review from a team as a code owner October 2, 2025 20:28
@lekhmanrus lekhmanrus requested review from crisbeto and wagnermaciel and removed request for a team October 2, 2025 20:28
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 2, 2025
@mmalerba mmalerba merged commit b61d884 into angular:main Oct 2, 2025
26 checks passed
@mmalerba
Copy link
Contributor

mmalerba commented Oct 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba pushed a commit that referenced this pull request Oct 2, 2025
@lekhmanrus @mmalerba
fix(material-date-fns-adapter): parse time string containing only hou…
2d1f8d0 
…rs (#31978)

close #31837

(cherry picked from commit b61d884)
adolgachev pushed a commit to adolgachev/components that referenced this pull request Oct 19, 2025
@lekhmanrus @adolgachev
fix(material-date-fns-adapter): parse time string containing only hou…
9bad76b 
…rs (angular#31978)

close angular#31837
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 2, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel is a code owner automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(matTimePicker): dateFnsAdapter incorrectly parse hours

2 participants

@lekhmanrus @mmalerba