-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(screenshot): Add screenshot function to e2e test (button and checkbox) #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,22 @@ | ||
| import {browser, by, element} from 'protractor'; | ||
| import {screenshot} from '../../screenshot'; | ||
|
|
||
|
|
||
| describe('button', function () { | ||
| describe('disabling behavior', function () { | ||
| beforeEach(function() { | ||
| browser.get('/button'); | ||
| }); | ||
|
|
||
| it('should prevent click handlers from executing when disabled', function () { | ||
| element(by.id('test-button')).click(); | ||
| expect(element(by.id('click-counter')).getText()).toEqual('1'); | ||
| screenshot('clicked once'); | ||
|
|
||
| element(by.id('disable-toggle')).click(); | ||
| element(by.id('test-button')).click(); | ||
| expect(element(by.id('click-counter')).getText()).toEqual('1'); | ||
| screenshot('click disabled'); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import * as fs from 'fs'; | ||
| import * as gulp from 'gulp'; | ||
| import * as path from 'path'; | ||
| import {browser} from 'protractor'; | ||
|
|
||
|
|
||
| function initializeEnvironment(jasmine: any) { | ||
| var reporter = new jasmine.JsApiReporter({}); | ||
| reporter.specStarted = function(result: any) { | ||
| jasmine.getEnv().currentSpec = result.fullName; | ||
| }; | ||
| jasmine.getEnv().addReporter(reporter); | ||
| } | ||
|
|
||
| initializeEnvironment(jasmine); | ||
|
|
||
| export class Screenshot { | ||
| id: string; | ||
| dir: string = '/tmp/angular-material2-build/screenshots/'; | ||
|
||
|
|
||
| /** The filename used to store the screenshot. */ | ||
| get filename(): string { | ||
| return this.id | ||
| .toLowerCase() | ||
| .replace(/\s/g, '_') | ||
| .replace(/[^/a-z0-9_]+/g, '') | ||
| + '.screenshot.png'; | ||
| } | ||
|
|
||
| /** The full path to the screenshot */ | ||
| get fullPath(): string { | ||
| return path.resolve(this.dir, this.filename); | ||
| } | ||
|
|
||
| constructor(id: string) { | ||
| this.id = `${jasmine.getEnv().currentSpec} ${id}`; | ||
| browser.takeScreenshot().then(png => this.storeScreenshot(png)); | ||
| } | ||
|
|
||
| /** Replaces the existing screenshot with the newly generated one. */ | ||
| storeScreenshot(png: any) { | ||
| if (!fs.existsSync(this.dir)) { | ||
| fs.mkdirSync(this.dir, '744'); | ||
| } | ||
|
|
||
| if (fs.existsSync(this.dir)) { | ||
| fs.writeFileSync(this.fullPath, png, {encoding: 'base64' }); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export function screenshot(id: string) { | ||
| return new Screenshot(id); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of storing this to
jasmine.getEnv(), would it work to create a variable at the file level and update that? E.g.,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just realized: we should make sure that the test results are still being reported normally with the custom report installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to file-level variable.
Constructor
JsApiReporter({specStarted})is not working.Tested the test results are being reported normally.