feat(@angular/cli): add support for ng-add packages that should not b… #15815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
…e saved as `dependencies`
With this change the CLI offers a way for a package authors to specify if during `ng add` the package should be saved as a `dependencies`, `devDependencies` or not saved at all.
Such config needs to be specified in `package.json`
Example:
```json
"ng-add": {
"save": false
}
```
Possible values are;
- false - Don't add the package to `package.json`
- true - Add the package to the `dependencies`
- `dependencies` - Add the package to the `dependencies`
- `devDependencies` - Add the package to the `devDependencies`
Closes #12003 , closes #15764 and closes #13237
`@angular/pwa` is not needed as a dependency. This is because the pwa package is a schematic and is only used once when adding pwa capabilities to your application. After that, this package is not used anymore. Closes #15764
clydin
approved these changes
Oct 14, 2019
alan-agius4
added a commit
to alan-agius4/ngx-deploy-npm
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
alan-agius4
added a commit
to alan-agius4/ng-deploy-azure
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
alan-agius4
added a commit
to alan-agius4/ng-deploy-now
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
alan-agius4
added a commit
to alan-agius4/angular-cli-ghpages
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
alan-agius4
added a commit
to alan-agius4/netlify-builder
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
This was referenced Nov 6, 2019
JohannesHoppe
pushed a commit
to angular-schule/angular-cli-ghpages
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
JohannesHoppe
pushed a commit
to angular-schule/ngx-deploy-starter
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815 (cherry picked from commit 3dfd8d6) closes #12 see angular-schule/angular-cli-ghpages#81
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(@angular/cli): add support for ng-add packages that should not be saved as
dependenciesWith this change the CLI offers a way for a package authors to specify if during
ng addthe package should be saved as adependencies,devDependenciesor not saved at all.Such config needs to be specified in
package.jsonExample:
Possible values are;
package.jsondependenciesdependencies- Add the package to thedependenciesdevDependencies- Add the package to thedevDependenciesCloses #12003 , closes #15764 and closes #13237