Skip to content

chore: export DevtoolsFeature type #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

chore: export DevtoolsFeature type #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/ngrx-toolkit/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export {
export { renameDevtoolsName } from './lib/devtools/rename-devtools-name';
export { patchState, updateState } from './lib/devtools/update-state';
export { withDevToolsStub } from './lib/devtools/with-dev-tools-stub';
export { withDevtools } from './lib/devtools/with-devtools';
export { DevtoolsFeature, withDevtools } from './lib/devtools/with-devtools';

export {
createEffects,
Expand Down
5 changes: 4 additions & 1 deletion libs/ngrx-toolkit/src/lib/devtools/with-devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import {
} from '@ngrx/signals';
import { DefaultTracker } from './internal/default-tracker';
import {
DevtoolsFeature,
DevtoolsFeature as DevtoolsFeatureInternal,
Copy link
Collaborator

@rainerhahnekamp rainerhahnekamp Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you rename it here and reverse it later?

Copy link
Collaborator Author

@michael-small michael-small Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not renamed, there is a name conflict.

Import declaration conflicts with local declaration of 'DevtoolsFeature'

image

DevtoolsInnerOptions,
} from './internal/devtools-feature';
import { DevtoolsSyncer } from './internal/devtools-syncer.service';
import { ReduxDevtoolsExtension } from './internal/models';

// Users requested that we export this type: https://github.com/angular-architects/ngrx-toolkit/issues/178
export type DevtoolsFeature = DevtoolsFeatureInternal;

declare global {
interface Window {
__REDUX_DEVTOOLS_EXTENSION__: ReduxDevtoolsExtension | undefined;
Expand Down