Skip to content

Commit a917bb6

Browse files
committed
refactor(nf*): remove useless check builder
1 parent 90908be commit a917bb6

File tree

1 file changed

+23
-24
lines changed
  • libs/native-federation/src/builders/build

1 file changed

+23
-24
lines changed

libs/native-federation/src/builders/build/builder.ts

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export async function* runBuilder(
7474
if (builder === '@angular-devkit/build-angular:browser-esbuild') {
7575
logger.info('.: NATIVE FEDERATION - UPDATE NEEDED :.');
7676
logger.info('');
77-
logger.info('Since version 17.1, Native Federation uses Angular\'s');
77+
logger.info("Since version 17.1, Native Federation uses Angular's");
7878
logger.info('Application-Builder and its Dev-Server.');
7979
logger.info('');
8080
logger.info('If you are sill on Angular 17.0.x, please update to');
@@ -142,7 +142,7 @@ export async function* runBuilder(
142142
server: 'server',
143143
media: 'media',
144144
...(typeof outputPath === 'string' ? undefined : outputPath),
145-
base: typeof outputPath === 'string' ? outputPath : outputPath.base
145+
base: typeof outputPath === 'string' ? outputPath : outputPath.base,
146146
};
147147

148148
const i18n = await getI18nConfig(context);
@@ -168,7 +168,7 @@ export async function* runBuilder(
168168
tsConfig: options.tsConfig,
169169
verbose: options.verbose,
170170
watch: false, // options.watch,
171-
dev: !!nfOptions.dev
171+
dev: !!nfOptions.dev,
172172
};
173173

174174
const activateSsr = nfOptions.ssr && !nfOptions.dev;
@@ -185,8 +185,8 @@ export async function* runBuilder(
185185
(e) => e !== 'tslib'
186186
);
187187
}
188-
}
189-
}
188+
},
189+
},
190190
];
191191

192192
// SSR build fails when externals are provided via the plugin
@@ -219,13 +219,13 @@ export async function* runBuilder(
219219
'Content-Type': mimeType,
220220
'Access-Control-Allow-Origin': '*',
221221
'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE',
222-
'Access-Control-Allow-Headers': 'Content-Type'
222+
'Access-Control-Allow-Headers': 'Content-Type',
223223
});
224224
res.end(body);
225225
} else {
226226
next();
227227
}
228-
}
228+
},
229229
];
230230

231231
const memResults = new MemResults();
@@ -271,25 +271,24 @@ export async function* runBuilder(
271271

272272
const appBuilderName = '@angular/build:application';
273273

274-
275274
const builderRun = runServer
276275
? serveWithVite(
277-
normOuterOptions,
278-
appBuilderName,
279-
_buildApplication,
280-
context,
281-
nfOptions.skipHtmlTransform
282-
? {}
283-
: { indexHtml: transformIndexHtml(nfOptions) },
284-
{
285-
buildPlugins: plugins as any,
286-
middleware
287-
}
288-
)
276+
normOuterOptions,
277+
appBuilderName,
278+
_buildApplication,
279+
context,
280+
nfOptions.skipHtmlTransform
281+
? {}
282+
: { indexHtml: transformIndexHtml(nfOptions) },
283+
{
284+
buildPlugins: plugins as any,
285+
middleware,
286+
}
287+
)
289288
: buildApplication(options, context, {
290-
codePlugins: plugins as any,
291-
indexHtmlTransformer: transformIndexHtml(nfOptions)
292-
});
289+
codePlugins: plugins as any,
290+
indexHtmlTransformer: transformIndexHtml(nfOptions),
291+
});
293292

294293
// builderRun.output.subscribe(async (output) => {
295294
for await (const output of builderRun) {
@@ -408,7 +407,7 @@ function addDebugInformation(fileName: string, rawBody: string): string {
408407

409408
const sharedForVite = shared.map((s) => ({
410409
...s,
411-
packageName: `/@id/${s.packageName}`
410+
packageName: `/@id/${s.packageName}`,
412411
}));
413412

414413
remoteEntry.shared = [...shared, ...sharedForVite];

0 commit comments

Comments
 (0)